From 7e888e46dfc6dd4e468bfe2d300ccb60e28bdc6d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Raj=20Achuta=F0=9F=A4=96?= <raj.achuta@goguardian.com>
Date: Wed, 22 Mar 2023 11:48:06 +0530
Subject: [PATCH] fix(update): handle $and & $or in array filters.

---
 .../update/removeUnusedArrayFilters.js        | 37 +++++++++++++++----
 .../update.removeUnusedArrayFilters.test.js   | 19 ++++++++++
 2 files changed, 48 insertions(+), 8 deletions(-)
 create mode 100644 test/helpers/update.removeUnusedArrayFilters.test.js

diff --git a/lib/helpers/update/removeUnusedArrayFilters.js b/lib/helpers/update/removeUnusedArrayFilters.js
index d4606285212..fbe62c2096c 100644
--- a/lib/helpers/update/removeUnusedArrayFilters.js
+++ b/lib/helpers/update/removeUnusedArrayFilters.js
@@ -7,12 +7,33 @@
  */
 
 module.exports = function removeUnusedArrayFilters(update, arrayFilters) {
-  const updateKeys = Object.keys(update).map(key => Object.keys(update[key])).reduce((cur, arr) => cur.concat(arr), []);
-  return arrayFilters.filter(obj => {
-    const firstKey = Object.keys(obj)[0];
-    const firstDot = firstKey.indexOf('.');
-    const arrayFilterKey = firstDot === -1 ? firstKey : firstKey.slice(0, firstDot);
-
-    return updateKeys.find(key => key.includes('$[' + arrayFilterKey + ']')) != null;
+  const updateKeys = Object.keys(update)
+    .map((key) => Object.keys(update[key]))
+    .reduce((cur, arr) => cur.concat(arr), []);
+  return arrayFilters.filter((obj) => {
+    return _checkSingleFilterKey(obj, updateKeys);
   });
-};
\ No newline at end of file
+};
+
+function _checkSingleFilterKey(arrayFilter, updateKeys) {
+  const firstKey = Object.keys(arrayFilter)[0];
+
+  if (firstKey === '$and' || firstKey === '$or') {
+    if (!Array.isArray(arrayFilter[firstKey])) {
+      return false;
+    }
+    return (
+      arrayFilter[firstKey].find((filter) =>
+        _checkSingleFilterKey(filter, updateKeys)
+      ) != null
+    );
+  }
+
+  const firstDot = firstKey.indexOf('.');
+  const arrayFilterKey =
+    firstDot === -1 ? firstKey : firstKey.slice(0, firstDot);
+
+  return (
+    updateKeys.find((key) => key.includes('$[' + arrayFilterKey + ']')) != null
+  );
+}
diff --git a/test/helpers/update.removeUnusedArrayFilters.test.js b/test/helpers/update.removeUnusedArrayFilters.test.js
new file mode 100644
index 00000000000..d5b82f0a30f
--- /dev/null
+++ b/test/helpers/update.removeUnusedArrayFilters.test.js
@@ -0,0 +1,19 @@
+'use strict';
+
+const assert = require('assert');
+const removeUnusedArrayFilters = require('../../lib/helpers/update/removeUnusedArrayFilters');
+
+describe('removeUnusedArrayFilters', function() {
+  it('respects `$or` (gh-10696)', function() {
+    const update = {
+      $set: {
+        'requests.$[i].status.aa': 'ON_GOING',
+        'requests.$[i].status.bb': 'ON_GOING'
+      }
+    };
+    const arrayFilters = [{ $or: [{ 'i.no': 1 }] }];
+
+    const ret = removeUnusedArrayFilters(update, arrayFilters);
+    assert.deepEqual(ret, [{ $or: [{ 'i.no': 1 }] }]);
+  });
+});
\ No newline at end of file