fix(update): make upsert option consistently handle truthy values, no…

…t just booleans, for updateOne() Fix #5839
Automattic · Nov 28, 2017 · 4d4dfa1 · 4d4dfa1
1 parent 5e279f4
commit 4d4dfa1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/query.js b/lib/query.js
@@ -1183,6 +1183,10 @@ Query.prototype._optionsForExec = function(model) {
     options.readPreference = model.schema.options.read;
   }
 
+  if (options.upsert !== void 0) {
+    options.upsert = !!options.upsert;
+  }
+
   return options;
 };
 

diff --git a/test/model.update.test.js b/test/model.update.test.js
@@ -2840,7 +2840,7 @@ describe('model: update:', function() {
         name: String
       });
 
-      var Model = db.model('gh3677', schema);
+      var Model = db.model('gh5839', schema);
 
       var opts = { upsert: 1 };
       Model.update({ name: 'Test' }, { name: 'Test2' }, opts, function(error) {