Typescript instanceof mongoose.Error

[amorimfilipe]

Do you want to request a feature or report a bug?

bug

What is the current behavior?

Following the example in https://mongoosejs.com/docs/api/error.html#error_Error

const Model = mongoose.model('Test', new mongoose.Schema({ answer: Number }))
const doc = new Model({ answer: 'not a number' })
const err = doc.validateSync()

err instanceof mongoose.Error // true

I got the error in err instanceof mongoose.Error

namespace Error
The right-hand side of an 'instanceof' expression must be of type 'any' or of a type assignable to the 'Function' interface type.ts(2359)

If the current behavior is a bug, please provide the steps to reproduce.

What are the versions of Node.js, Mongoose and MongoDB you are using? Note that "latest" is not a version.

node 16.14.2
mongoose 6.3.4

[Uzlopak]

It is a documentation error. You have to check against mongoose.Error.ValidationError

[Uzlopak]

Accidently closed

[amorimfilipe]

@Uzlopak Maybe I am misunderstanding something, but from code

// mongoose\lib\index.js

/**
 * The [MongooseError](#error_MongooseError) constructor.
 *
 * @method Error
 * @api public
 */

Mongoose.prototype.Error = require('./error/index');

// mongoose\lib\error\index.js

/**
 * MongooseError constructor. MongooseError is the base class for all
 * Mongoose-specific errors.
 *
 * #### Example:
 *     const Model = mongoose.model('Test', new Schema({ answer: Number }));
 *     const doc = new Model({ answer: 'not a number' });
 *     const err = doc.validateSync();
 *
 *     err instanceof mongoose.Error; // true
 *
 * @constructor Error
 * @param {String} msg Error message
 * @inherits Error https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Error
 */

const MongooseError = require('./mongooseError');

module.exports = exports = MongooseError;

// mongoose\lib\error\mongooseError.js

class MongooseError extends Error { }

Object.defineProperty(MongooseError.prototype, 'name', {
  value: 'MongooseError'
});

module.exports = MongooseError;

So shouldn't instanceof mongoose.Error work or I am missing something? I am trying to validate against MongooseError instead of every single error.

[Uzlopak]

@amorimfilipe

Thanks for the feedback. It should be now fixed in master.

[amorimfilipe]

@Uzlopak Thank you!