feat: Add batch processing for eachAsync #9902
Conversation
|
Not the proudest code I've written, but it does the job with minimal changes but honestly, I would prefer for it to be a standalone method. |
khaledosama999
changed the title
|
I can rebase the feature on the master branch and change the base of the PR to master if you want |
There was a problem hiding this comment.
Good Job Mr @khaledosama999 , I think it will be a good feature for me
| } | ||
|
|
||
| // If the current documents size is less than the provided patch size don't process the documents yet | ||
| if (batchSize && documentsBatch.length !== batchSize) { |
There was a problem hiding this comment.
I'd do documentsBatch.length < batchSize just in case, but I don't see that being a blocker here.
|
@vkarpov15 No fine by me, like I said if you want me to rebase the feature on another branch that's fine. |
|
My mistake, I didn't notice this was against the 6.0 branch. Would it be possible for you to rebase this against the 5.12 branch? 6.0 is a major backwards breaking release that we plan on shipping in early 2021, 5.12 is a feature release we're planning on shipping in Feb '21. |
|
No problem, give me a few mins |
khaledosama999
force-pushed
the
gh-9861
branch
from
37d39e2
to
007fb69
Compare
|
@vkarpov15 Done, no idea why Travis CI failed though. |
Resolves #9861