fix: do not break wp_update_term #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
approved these changes
Jul 30, 2024
|
🎉 This PR is included in version 1.5.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Aug 13, 2024
# [2.0.0](v1.4.0...v2.0.0) (2024-08-13) ### Bug Fixes * do not break wp_update_term ([#51](#51)) ([70c0ea4](70c0ea4)) * update dependencies to support `@wordpress/scripts` ([#45](#45)) ([de1a172](de1a172)) ### Features * **ga:** add brand as custom parameter to GA4 ([bff4df3](bff4df3)) ### BREAKING CHANGES * Updates dependencies for compatibility with WordPress 6.6.*, but breaks JS in WordPress 6.5.* and below. If you need support for WP 6.5.*, please do not upgrade to this new major version. * chore: refactor for newspack-scripts dependency updates * chore: update newspack-scripts to v5.6.0-alpha.3 * chore: add .stylelintrc.js * chore: update newspack-scripts to v5.6.0-alpha.4 * fix: add missing Prettier config files * chore: update newspack-scripts to 5.6.0-alpha.5 * chore: update newspack-scripts to v5.6.0-alpha.7 * fix: format SCSS * chore: update newspack-scripts to v5.6.0-alpha.8 * fix: phpcs errors * chore: update newspack-components to v3.0.0 * fix: phpcs error * chore: bump newspack-scripts to v5.5.2
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is easily reproduceable, because I thought we would have caught it earlier.
But that's how I reproduce it:
Just open the wp shell and run:
wp_update_term( 16, 'category', ['parent' => '' ] );, where16is the ID of a category on your site.What I'm seeing is the shell exiting with
Error: The link you followed has expired.Testing
Edit a tag or category, add a primary brand and save. Make sure it persists. Edit it again and mark primary category as None, make sure it persists.
Run that command on WP Shell again and confirm there are no errors