fix(sync): use newspack_esp_sync_contact filter for the network_registration_site field

[miguelpeixe]

Automattic/newspack-plugin#3359 introduced a new newspack_esp_sync_contact filter, which should be used for any contact data manipulation during a sync.

This change also removes an unnecessary hook that had no effect.

How to test

1. Make sure your Hub and Node sites are able to sync contact:

• Enable RAS
• Enable ESP Sync in Newspack > Engagement > Advanced
• Make sure to select a Master list
• Make sure the "Network Registration Site" field is enabled
• Make sure testing sites have define( 'NEWSPACK_ALLOW_READER_SYNC', true );
• Make sure the main plugin is running latest trunk
• Also make sure you have define( 'NEWSPACK_LOG_LEVEL', 3); to be able to see ESP sync logs

2. Watch the logs tail -f /tmp/2024-mm-dd--newspack_esp_sync

3. Visit the Node site as an anonymous visitor and register

4. Confirm you see a RAS Reader registration log entry and the data includes the "Registration Site" with the Node url

5. Wait for the event to propagate to the Hub, (or run wp newspack-network process-webhooks)

6. Confirm you now see a RAS Newspack Network: User propagated from another site in the network. in the Hub's logs, and that the data includes the "Registration Site" with the Node url

7. Now as an anonymous reader visit the Hub and register

8. Make sure you see the RAS Reader registration event on the Hub's log, with "Registration Site"

9. Go to the Node and Pull the latest events in Newspack Network > Node Settings

10. Confirrm you see the RAS Newspack Network: User propagated from another site in the network. in the Node's logs, with the "Registration Site" filled

[miguelpeixe]

@leogermani Do you want to take over this PR to look at the newspack_register_reader_metadata hook or is it safe to just remove it?

[leogermani]

Yes I want to test it in more depth

[leogermani]

@miguelpeixe I've tested and successfully removed that filter that weren't doing anything.

I've updated the test instructions if you want to have a look

[miguelpeixe]

Tested well for me.

[matticbot]

🎉 This PR is included in version 2.2.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀