Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync billing and shipping addresses #50

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

chickenn00dle
Copy link
Contributor

Closes /0/1206331646877116/1206510843311106/f

This PR adds address data to synced user meta.

Screenshot 2024-02-13 at 15 49 22

Testing Instructions

  1. On a node site, register a new reader by going through the donation flow as an unregistered user. (Make sure you check the register account option if you make a one-time purchase)
  2. Check that the node site's network node settings contains an update user event, and this event contains billing information.
    Screenshot 2024-02-13 at 15 52 41
  3. Once the event has been sent to the hub site, check your hub site for the respective reader and confirm the billing details are present in wp-admin > users menu
  4. On the hub site, log in as the newly created reader and go to my account
  5. Confirm an addresses tab appears in my account and that the billing address is present
  6. Edit the billing and shipping addresses and check the hub event log, confirming your changes are present in a user updated event
  7. Wait for the event to be pulled on the node site from step 1 and then confirm the changes are present in wp-admin as well as in my account for the logged in user

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@leogermani
Copy link
Contributor

One thing I'm curious. Have you tested editing the profile from the My Account page to see if the event is triggered and the info is synced? I only tested this editing the user from the admin panel

@adekbadek
Copy link
Member

I've tested editing from /my-account, it's synced.

@chickenn00dle chickenn00dle force-pushed the feat/sync-billing-and-shipping-addresses branch from f4ce3ff to d9b012b Compare February 14, 2024 17:07
@chickenn00dle
Copy link
Contributor Author

I only tested this editing the user from the admin panel

@leogermani, just to be clear before merging, were there issues with editing via admin panel?

@leogermani
Copy link
Contributor

@chickenn00dle No! It's good to go

@chickenn00dle chickenn00dle merged commit 6a05580 into trunk Feb 14, 2024
3 checks passed
@adekbadek adekbadek deleted the feat/sync-billing-and-shipping-addresses branch February 15, 2024 08:16
matticbot pushed a commit that referenced this pull request Feb 15, 2024
# [1.2.0-alpha.2](v1.2.0-alpha.1...v1.2.0-alpha.2) (2024-02-15)

### Bug Fixes

* assorted error handling fixes ([#52](#52)) ([234f883](234f883))
* dynamic class property deprecated warnings ([#47](#47)) ([693865c](693865c))
* prevent coauthors capability check infinite loop ([#46](#46)) ([9565cef](9565cef))
* set Yoast primary category ([#41](#41)) ([3457d19](3457d19))

### Features

* sync billing and shipping addresses ([#50](#50)) ([6a05580](6a05580))
* sync publish, trash post statuses ([#42](#42)) ([fd5d8b9](fd5d8b9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 20, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-02-20)

### Bug Fixes

* assorted error handling fixes ([#52](#52)) ([234f883](234f883))
* **data-listeners:** handle no user in wc data update ([4eeefc0](4eeefc0))
* dynamic class property deprecated warnings ([#47](#47)) ([693865c](693865c))
* prevent coauthors capability check infinite loop ([#46](#46)) ([9565cef](9565cef))
* race condition when creating a Node ([1946473](1946473))
* set Yoast primary category ([#41](#41)) ([3457d19](3457d19))

### Features

* **ci:** add epic/* release workflow and rename `master` to `trunk` ([#39](#39)) ([9cee51d](9cee51d))
* sync billing and shipping addresses ([#50](#50)) ([6a05580](6a05580))
* sync publish, trash post statuses ([#42](#42)) ([fd5d8b9](fd5d8b9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants