Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-log): only show users filter with environment constant #86

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Mar 29, 2024

On production sites, the list of users in the event log filter can get very, very long and cause significant slowdowns when viewing the Event Log admin page. This change simply hides the Users filter on this page unless a NEWSPACK_NETWORK_EVENT_LOG_SHOW_USERS_FILTER constant is set in wp-config.php.

To test:

  1. On a Hub site, visit Newspack Network > Event Log and confirm that the Users select dropdown is no longer shown.
  2. Add define( 'NEWSPACK_NETWORK_EVENT_LOG_SHOW_USERS_FILTER', true ); to wp-config.php and confirm that it reappears

@dkoo dkoo self-assigned this Mar 29, 2024
@dkoo dkoo requested a review from a team as a code owner March 29, 2024 16:33
@dkoo dkoo changed the base branch from trunk to release March 29, 2024 16:34
@jaredrethman jaredrethman self-requested a review March 29, 2024 18:30
Copy link
Collaborator

@jaredrethman jaredrethman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good + tested and works. Approved!

@dkoo dkoo merged commit cd4a91a into release Mar 29, 2024
3 checks passed
matticbot pushed a commit that referenced this pull request Mar 29, 2024
## [1.4.1](v1.4.0...v1.4.1) (2024-03-29)

### Bug Fixes

* **event-log:** only show users filter with environment constant ([#86](#86)) ([cd4a91a](cd4a91a))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 29, 2024
# [1.5.0-alpha.2](v1.5.0-alpha.1...v1.5.0-alpha.2) (2024-03-29)

### Bug Fixes

* **event-log:** only show users filter with environment constant ([#86](#86)) ([cd4a91a](cd4a91a))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.5.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants