Fix: Dynamically fetch message ID in ActiveCampaign test emails

[claudiulodro]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Note: This is a hotfix PR.

This PR fixes an issue I discovered on some client sites which is also reproducible in my local environment.

When a new temporary campaign is created in ActiveCampaign to send a test email, it uses the message ID saved onto the post. This message is not necessarily associated with the temporary campaign, so the test send will fail.

I'm not sure if the approach I took here is the way to go, or if it would be better to somehow associate the message from the "real" campaign with the temporary campaign, so that this check isn't needed. Let me know what you think.

How to test the changes in this Pull Request:

1. This part happens naturally for every new newsletter on my local running only the trunk version of Plugin, Blocks, Ads, and Newsletters, but it did not happen in @adekbadek's testing. Start a new newsletter from a template, add all the necessary information, save it as draft, and send a test email.
2. Before applying this patch you should get a "Sending test campaign failed: Message not sent" error:

4. After applying this patch it should successfully send:

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

I was able to replicate the issue after repeatedly sending multiple tests. This fixed the issue for me.

[dkoo]

@claudiulodro if this is supposed to be a hotfix, should it be rebased on release?

[claudiulodro]

Thanks for the quick review!

I always remember to branch off release but never remember to merge to release. 😆 Fixed now. I'll merge Monday so it doesn't deploy Friday afternoon.

[matticbot]

🎉 This PR is included in version 3.1.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀