Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for icons in the Social Icons block #595

Closed
tmmbecker opened this issue Oct 14, 2021 · 3 comments · Fixed by #603
Closed

Add support for icons in the Social Icons block #595

tmmbecker opened this issue Oct 14, 2021 · 3 comments · Fixed by #603
Assignees
Labels

Comments

@tmmbecker
Copy link

It's possible to add the Social Icons block to a newsletter but adding the specific buttons is weirdly disabled. Reported by WCP and replicated on both WCP and Model Home:

Screen.Capture.on.2021-10-14.at.11-03-00.mp4

Here's what I expected:

social-icons-block-click-plus-to-add

There are no errors that I can see in the console, etc. but I'm sure that I'm missing something here.

As a shorter-term stop-gap in the event that we can't get this fixed quickly, can we remove that block from the list of options in the Newsletter CPT?

@tmmbecker tmmbecker added the bug Something isn't working label Oct 14, 2021
@tmmbecker
Copy link
Author

It was working as we have it set up already at the bottom of our newsletters on Model Home:

Screen Shot on 2021-10-14 at 11-13-53

But it's no longer possible to add new buttons to the block.

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.35.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants