feat(ras-acc): make auth flow UI text filterable

[chickenn00dle]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1206943664367847/1205669646691019/f

This PR makes the previously hard-coded reader activation auth flow text filterable:

Note: I have not made any of the errors, basic input labels and placeholders, or Google signin related text filterable. Let me know if you think any of these should be added.

How to test the changes in this Pull Request:

1. Go through the sign in and registration flows and confirm none of the text is broken
2. Add the following filter and test the sign in and registration flows again. Confirm all of the text has been replaced as expected:

add_filter( 'newspack_reader_activation_auth_labels', function( $labels ) {
	return [
		'invalid_email'           => 'banana',
		'invalid_password'        => 'banana',
		'invalid_display'         => 'banana',
		'blocked_popup'           => 'banana',
		'code_resent'             => 'banana',
		'create_account'          => 'banana',
		'signin'                  => [
			'title'           => 'banana',
			'success_title'   => 'banana',
			'success_message' => 'banana',
			'continue'        => 'banana',
			'resend_code'     => 'banana',
			'otp'             => 'banana',
			'forgot_password' => 'banana',
			'create_account'  => 'banana',
			'register'        => 'banana',
			'go_back'         => 'banana',
			'set_password'    => 'banana',
		],
		'register'                => [
			'title'               => 'banana',
			'success_title'       => 'banana',
			'success_description' => 'banana',
		],
		'verify'                  => 'banana',
		'magic_link'              => 'banana',
		'password_reset_interval' => 'banana',
		'account_link'            => [
			'signedin'  => 'banana',
			'signedout' => 'banana',
		],
		'newsletters'             => 'banana',
	];
} );

3. Replace the above filter with the following and test the sign in and registration flows one more time. This time confirm all of the default text appears as expected:

add_filter( 'newspack_reader_activation_auth_labels', function( $labels ) {
	return [];
} );

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[adekbadek]

Left one suggestion.

[adekbadek]

Kind of a nit: this should be a deep merge, if the filter is to be used as suggested in the PR description. With the following use, the whole signin key is replaced, and sub-keys' values other than title are empty:

		add_filter(
			'newspack_reader_activation_auth_labels',
			function( $labels ) {
				return [
					'signin' => [
						'title' => 'banana',
					],
				];
			}
		);

The proper use of the filter in this case should be:

		add_filter(
			'newspack_reader_activation_auth_labels',
			function( $labels ) {
				$labels['signin']['title'] = 'banana';
				return $labels;
			}
		);

Just pointing this out since there's an array_merge in use, suggesting all defaults will be merged with what's supplied via the filter.

[chickenn00dle]

Good suggestion!

Rather than perform a deep merge on every call to get_reader_auth_labels though, I decided to adjust the logic for setting the labels cache to account for both usages of the filters above. Let me know what you think:

5b42975

[dkoo]

🍌🍌🍌

[matticbot]

🎉 This PR is included in version 3.6.0-epic-ras-acc.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀