fix(ras): sync purchase data only for most recent order/subscription

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Tweaks the reader data sync behavior so that any purchase-related fields only relate to the reader's most recent active order/subscription, if any. It's possible for a single reader to have more than one subscription in different states, so in this case an active one should take precedence when it comes to contact data in the connected ESP.

How to test the changes in this Pull Request:

1. Publish three different non-donation subscription-type products with different attributes (name, price, billing period, etc.) so they're easily distinguished in the connected ESP data.
2. As a reader, purchase subscriptions for two of the products.
3. As an admin, force immediate cancellation of the older subscription (in WooCommerce > Subscriptions > Edit Subscription, change the status to "Cancelled" or "Expired").
4. On release, log in as the reader in a new session.
5. In the connected ESP, observe that the contact's metadata reflects a mix of data from both subscriptions: e.g. the NP_Current Subscription End Date will reflect the time you changed the status of the cancelled subscription in step 3, but the NP_Membership Status, NP_Billing Cycle, * Payment Date fields, etc. will all reflect the more recent active one.
6. Check out this branch and purchase a third subscription with the third product (so you should have one cancelled/expired sub and 2x active ones). Confirm that the contact data in the ESP now reflects only this most recent subscription, and that NP_Current Subscription End Date has been emptied out (because there's an active subscription, so there shouldn't be an end date).
7. As an admin, cancel the older active subscription. Confirm that the contact data in the ESP still reflects only the remaining active subscription.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207153288488122

[adekbadek]

In my testing, only the "total paid" field gets updated*. I've two products with different prices:

1. Add subscription w/ product A -> ESP updated as expected
2. Add subscription w/ product B -> only "total paid" field updated
3. Cancel subscription for product A -> only "end date" is updated

In other words, fields don't get overwritten, only previously empty fields are updated.

* by which I mean both what I see in ESP (AC) and the value of $metadata here:

newspack-plugin/includes/reader-revenue/woocommerce/class-woocommerce-connection.php

Line 367 in 4df766b

$metadata = array_merge( $order_metadata, $metadata );

[dkoo]

In other words, fields don't get overwritten, only previously empty fields are updated.

@adekbadek hmm, I can't replicate this. Are your subscription products set to both "virtual" and "downloadable"? If not, their orders might be stuck in "processing" status, and they won't be found by the method that looks for the last completed order (get_last_successful_order). #3072 should resolve this for most sites.

[adekbadek]

Are your subscription products set to both "virtual" and "downloadable"? If not, their orders might be stuck in "processing" status, and they won't be found

That was it! One of my test products was not "downloadable". Works fine now!

[matticbot]

🎉 This PR is included in version 3.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.0.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀