Feat/rss vs wc memberships #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
the
[Status] Needs Review
dkoo
approved these changes
May 30, 2024
There was a problem hiding this comment.
I'm approving since this mostly works, but I was having some trouble that I'm not sure is due to my test site setup or something else:
- On my local dev site, I had trouble getting my feeds to display full content instead of excerpts no matter which settings I enabled in WooCommerce Memberships settings or general WP > Reading settings.
- On another test site, updates seem to take a few minutes to take effect. Probably expected since RSS feeds are only regenerated on an interval, right?
github-actions
bot
added
[Status] Approved
Co-authored-by: Derrick Koo <dkoo@users.noreply.github.com>
To clarify, this only happened on a local dev site, but did not when testing on another test site?
In my testing the updates were not delayed. Perhaps some caching was in place on the site you've tested with? |
That's right—since I didn't see it on a fresh test site, I think it's a peculiarity of my dev environment, but wanted to mention just in case we see it happen elsewhere after rollout. |
dkoo
approved these changes
Jun 3, 2024
|
🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.2.0-epic-ia.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dkoo
pushed a commit
that referenced
this pull request
Jun 11, 2024
* feat(rss): hide WC Memberships meta box when editing a feed * feat(wc-memberships): allow to skip content restrictions in RSS feeds
|
🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jun 24, 2024
# [4.4.0-alpha.1](v4.3.3...v4.4.0-alpha.1) (2024-06-24) ### Bug Fixes * add modified check before updating donation product ([#3183](#3183)) ([208c55e](208c55e)) * allow `exact` prop on Wizard Route ([9da6da9](9da6da9)) * ci / eslint ([1d6adcd](1d6adcd)) * ci / eslint ([b95580a](b95580a)) * ci / eslint ([beadc45](beadc45)) * ci / typescript ([2c1e092](2c1e092)) * circle ci / eslint ([ab74e90](ab74e90)) * circle ci / eslint ([4d383da](4d383da)) * circle ci / eslint ([6389972](6389972)) * load optional modules after settings ([#3165](#3165)) ([69cc5ac](69cc5ac)) * merge conflicts and various minor refactoring ([ca4fea8](ca4fea8)) * **pwa:** disable post request interception ([1587232](1587232)) * **reader-revenue-wizard:** separate billing fields section ([#3140](#3140)) ([41fb347](41fb347)) * remove icons import ([136a19a](136a19a)) * small tweaks to migrate-co-authors-guest-authors command ([2baa524](2baa524)) * text overflow ellipse ([d35df0b](d35df0b)) ### Features * add BoxContrast to components-demo ([23a8e5f](23a8e5f)) * add spinner to registration block submit button ([#3180](#3180)) ([ff1278f](ff1278f)) * added `<hr/>` between site status and quick action components ([982f67b](982f67b)) * added correct icon type to window.newspack_dashboard ([b5a5130](b5a5130)) * added dash card section components ([f9f3992](f9f3992)) * added quick actions component ([d37e3f3](d37e3f3)) * adding brand header and box-contrast component ([afb2e08](afb2e08)) * adding site status component ([ee01d09](ee01d09)) * applied PR feedback, error configuration ([7ef613e](7ef613e)) * boilerplate stylesheet for settings ([5f3f640](5f3f640)) * centralized wizards script initial ([6faf3d2](6faf3d2)) * dashboard & section initial ([eb3d1e6](eb3d1e6)) * dynamic component root loader ([389646a](389646a)) * icons ([5f3c740](5f3c740)) * initial app boilerplate ([9a3740c](9a3740c)) * initial settings and refactor ([d7d7da8](d7d7da8)) * **pwa:** pr feedback. moved anonymous function to static method ([1143a11](1143a11)) * RSS & WC Memberships ([#3146](#3146)) ([e649199](e649199)) * settings php initial ([e039c4b](e039c4b)) * **wizards:** new dashboard config and localize script ([2938b32](2938b32)) ### Reverts * **ia:** back to `trunk` ([69b2ba0](69b2ba0))
|
🎉 This PR is included in version 4.4.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 1, 2024
# [4.4.0](v4.3.4...v4.4.0) (2024-07-01) ### Bug Fixes * add modified check before updating donation product ([#3183](#3183)) ([208c55e](208c55e)) * allow `exact` prop on Wizard Route ([9da6da9](9da6da9)) * ci / eslint ([1d6adcd](1d6adcd)) * ci / eslint ([b95580a](b95580a)) * ci / eslint ([beadc45](beadc45)) * ci / typescript ([2c1e092](2c1e092)) * circle ci / eslint ([ab74e90](ab74e90)) * circle ci / eslint ([4d383da](4d383da)) * circle ci / eslint ([6389972](6389972)) * **cli/migrate-co-authors-guest-authors:** handle existing email address ([#3172](#3172)) ([1946bd0](1946bd0)) * **js:** skip regenerator-runtime fix for some files ([#3205](#3205)) ([1ecfd11](1ecfd11)) * load optional modules after settings ([#3165](#3165)) ([69cc5ac](69cc5ac)) * merge conflicts and various minor refactoring ([ca4fea8](ca4fea8)) * **pwa:** disable post request interception ([1587232](1587232)) * **reader-revenue-wizard:** separate billing fields section ([#3140](#3140)) ([41fb347](41fb347)) * remove icons import ([136a19a](136a19a)) * small tweaks to migrate-co-authors-guest-authors command ([2baa524](2baa524)) * text overflow ellipse ([d35df0b](d35df0b)) * udpate package-lock.json ([0054142](0054142)) * update newspack-scripts to v5.5.1 ([be81e62](be81e62)) * update newspack-scripts to v5.5.1 ([896caab](896caab)) ### Features * add BoxContrast to components-demo ([23a8e5f](23a8e5f)) * add spinner to registration block submit button ([#3180](#3180)) ([ff1278f](ff1278f)) * added `<hr/>` between site status and quick action components ([982f67b](982f67b)) * added correct icon type to window.newspack_dashboard ([b5a5130](b5a5130)) * added dash card section components ([f9f3992](f9f3992)) * added quick actions component ([d37e3f3](d37e3f3)) * adding brand header and box-contrast component ([afb2e08](afb2e08)) * adding site status component ([ee01d09](ee01d09)) * applied PR feedback, error configuration ([7ef613e](7ef613e)) * boilerplate stylesheet for settings ([5f3f640](5f3f640)) * centralized wizards script initial ([6faf3d2](6faf3d2)) * dashboard & section initial ([eb3d1e6](eb3d1e6)) * dynamic component root loader ([389646a](389646a)) * ensure regenerator-runtime is available (for WP 6.6) ([#3196](#3196)) ([9693e37](9693e37)) * **everlit:** added Everlit to plugins + refactor plugins in connections wizard ([#3188](#3188)) ([88124f8](88124f8)) * icons ([5f3c740](5f3c740)) * initial app boilerplate ([9a3740c](9a3740c)) * initial settings and refactor ([d7d7da8](d7d7da8)) * **pwa:** pr feedback. moved anonymous function to static method ([1143a11](1143a11)) * RSS & WC Memberships ([#3146](#3146)) ([e649199](e649199)) * settings php initial ([e039c4b](e039c4b)) * **wizards:** new dashboard config and localize script ([2938b32](2938b32)) ### Reverts * **ia:** back to `trunk` ([69b2ba0](69b2ba0))
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds an option to skip WC Memberships' content restrictions in RSS feeds. This is needed for publication which want to restrict content on the website, but still distribute it in news aggregation services.
Also, removes the WC Memberships meta box while editing an RSS feed, to avoid confusion.
How to test the changes in this Pull Request:
/feed, observe that not whole post content is sent in the payloadwp eval "\Newspack\Settings::activate_optional_module('rss');"* restrict all posts for ease of testing
Other information: