Add new ButtonCard component #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasguillot
added
the
[Status] Needs Review
dkoo
requested changes
May 14, 2021
| <div className="newspack-dashboard-card__contents"> | ||
| <Icon icon={ plugins } /> | ||
| <div className="newspack-dashboard-card__header"> | ||
| <Card className="newspack-dashboard-card"> |
There was a problem hiding this comment.
Why a regular Card here—is it just so we can use the strong in the message? Wonder if we could adapt the ButtonCard to render children if it exists instead of (or in addition to) the desc prop?
There was a problem hiding this comment.
It's not a link so it doesn't make sense to use a ButtonCard. It's also temporary and the Google oauth connection will be moved elsewhere.
dkoo
approved these changes
May 17, 2021
matticbot
pushed a commit
that referenced
this pull request
May 18, 2021
# [1.40.0-alpha.1](v1.39.0...v1.40.0-alpha.1) (2021-05-18) ### Bug Fixes * replace WP User Avatar with Simple Local Avatars ([#966](#966)) ([f980412](f980412)) * **oauth:** wpcom token saving ([24052d6](24052d6)) * **progress-bar:** radius when having headings ([#963](#963)) ([8347362](8347362)) * loading quiet anim time/height and margin when admin menu is folded ([#958](#958)) ([f297780](f297780)) ### Features * add an AutocompleteWithSuggestions component for reusability ([#952](#952)) ([460728d](460728d)) * add new ButtonCard component ([#961](#961)) ([eff9edf](eff9edf)) * add reusable blocks extended as supported plugin ([#968](#968)) ([10f9758](10f9758))
|
🎉 This PR is included in version 1.40.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 18, 2021
# [1.40.0](v1.39.0...v1.40.0) (2021-05-18) ### Bug Fixes * replace WP User Avatar with Simple Local Avatars ([#966](#966)) ([f980412](f980412)) * **oauth:** wpcom token saving ([24052d6](24052d6)) * **progress-bar:** radius when having headings ([#963](#963)) ([8347362](8347362)) * loading quiet anim time/height and margin when admin menu is folded ([#958](#958)) ([f297780](f297780)) ### Features * add an AutocompleteWithSuggestions component for reusability ([#952](#952)) ([460728d](460728d)) * add new ButtonCard component ([#961](#961)) ([eff9edf](eff9edf)) * add reusable blocks extended as supported plugin ([#968](#968)) ([10f9758](10f9758))
|
🎉 This PR is included in version 1.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds a brand new component:
ButtonCardto be used in the Dashboard and the Onboarding (for the upcoming migration step).How to test the changes in this Pull Request:
Other information: