fix: make sure sponsored categories, tags show sponsor info

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR fixes a regression in the Sponsors plugin, where sponsored categories and tags stopped displaying the sponsor information at the top of their individual archive pages.

This one is a little weird. Just looking at releases, this seems to have stopped working between 1.2.1 and 1.3.0, but I'm not actually sure why -- the changes in 1.3.0 alone don't seem like enough.

On top of that, the fix I landed on was something that was never in this part of the plugin -- the docs for get_term_by() say that the taxonomy is optional only if you're using term_taxonomy_id, but id definitely worked for a while. So I'm not sure if this is the best approach, or if it'd be better to pass the taxonomy to get_term_by(), or something else. Feedback welcome!

See 1200550061930446-as-1206174629624809

How to test the changes in this Pull Request:

1. Set up at least one sponsored category and at least one sponsored tag, and apply posts to each.
2. View the archive of one of these sponsored categories or tags, and note that it looks like a regular archive.

3. Apply the PR.
4. Refresh your archive; confirm that the sponsor's logo and description now appear at the top, and you no longer have an individual sponsor label for each post, but just at the top:

5. Check your other sponsored archives, and make sure they also look like this (both a category and tag).
6. Check some non-sponsored archives -- tags, categories, and author -- and sponsored posts in non-sponsored categories, and make sure they're displaying as expected.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[laurelfulford]

Thanks @adekbadek! 🙌

[matticbot]

🎉 This PR is included in version 1.12.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀