feat: avoid unnecessary queries if there are no published sponsors #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersonrabb
approved these changes
Nov 20, 2020
matticbot
pushed a commit
that referenced
this pull request
Nov 24, 2020
# [1.3.0-alpha.1](v1.2.1...v1.3.0-alpha.1) (2020-11-24) ### Features * avoid unnecessary queries if there are no published sponsors ([#46](#46)) ([587729c](587729c))
|
🎉 This PR is included in version 1.3.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 24, 2020
# [1.3.0](v1.2.1...v1.3.0) (2020-11-24) ### Features * avoid unnecessary queries if there are no published sponsors ([#46](#46)) ([587729c](587729c))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This adds a check for published sponsor posts before running any additional sponsor-related queries. If the site has no published sponsors, then there's no need to proceed with the sponsor queries.
How to test the changes in this Pull Request:
master, view the homepage and use debug bar to count the number of queries occurring withnewspack_spnsrs_cptas a query param. It will likely be a double-digit number, at least one per post rendered on the page.newspack_spnsrs_cptagain. The number should now be just1, and hopefully the "total query time" should also be slightly less.Other information: