-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ci images and NPM packages #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
All npm commands were executed without errors and the plugin is behaving as expected (no JS errors while using its functionality).
## [1.7.1-alpha.1](v1.7.0...v1.7.1-alpha.1) (2021-11-03) ### Bug Fixes * update ci images and NPM packages ([#72](#72)) ([21ccfbf](21ccfbf))
🎉 This PR is included in version 1.7.1-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.7.1](v1.7.0...v1.7.1) (2021-11-30) ### Bug Fixes * update ci images and NPM packages ([#72](#72)) ([21ccfbf](21ccfbf))
🎉 This PR is included in version 1.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
As seen on Automattic/newspack-ads#214, recent changes made to
circleci/php
resulted in our builds fail due to an incompatibility with ournode-sass
dependency.circleci/
images are being deprecated and will lose support starting December 2021. We should start moving towards maintained images.As with the other Newspack repositories that use CircleCI, this PR implements the use of
cimg/
images and updates some of the build dependencies.This PR also updates NPM packages to bring dependencies up-to-date with the latest Calypso dependencies. This means the required/supported NPM version is now v16.11.1.
How to test the changes in this Pull Request:
npm run lint
,npm run build
,npm run dev
).Other information: