Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ci images and NPM packages #72

Merged
merged 5 commits into from
Nov 3, 2021
Merged

fix: update ci images and NPM packages #72

merged 5 commits into from
Nov 3, 2021

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Nov 2, 2021

All Submissions:

Changes proposed in this Pull Request:

As seen on Automattic/newspack-ads#214, recent changes made to circleci/php resulted in our builds fail due to an incompatibility with our node-sass dependency.

circleci/ images are being deprecated and will lose support starting December 2021. We should start moving towards maintained images.

As with the other Newspack repositories that use CircleCI, this PR implements the use of cimg/ images and updates some of the build dependencies.

This PR also updates NPM packages to bring dependencies up-to-date with the latest Calypso dependencies. This means the required/supported NPM version is now v16.11.1.

How to test the changes in this Pull Request:

  1. Ensure that you can still run all linting and build commands (npm run lint, npm run build, npm run dev).
  2. Ensure that all CI jobs pass.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo requested a review from a team November 3, 2021 20:13
@dkoo dkoo self-assigned this Nov 3, 2021
@dkoo dkoo marked this pull request as ready for review November 3, 2021 20:16
@dkoo dkoo changed the title fix: update ci images fix: update ci images and NPM packages Nov 3, 2021
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

All npm commands were executed without errors and the plugin is behaving as expected (no JS errors while using its functionality).

@dkoo dkoo merged commit 21ccfbf into master Nov 3, 2021
@dkoo dkoo deleted the fix/circleci-build branch November 3, 2021 20:30
matticbot pushed a commit that referenced this pull request Nov 3, 2021
## [1.7.1-alpha.1](v1.7.0...v1.7.1-alpha.1) (2021-11-03)

### Bug Fixes

* update ci images and NPM packages ([#72](#72)) ([21ccfbf](21ccfbf))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.7.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 30, 2021
## [1.7.1](v1.7.0...v1.7.1) (2021-11-30)

### Bug Fixes

* update ci images and NPM packages ([#72](#72)) ([21ccfbf](21ccfbf))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants