From a8f600cd9dcf05b667624769255aa541086935f4 Mon Sep 17 00:00:00 2001 From: Donna Peplinskie Date: Thu, 14 Nov 2024 11:26:22 -0500 Subject: [PATCH] Update pre-merge checklist --- .github/PULL_REQUEST_TEMPLATE.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cd03196f02..b220fb1b7a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -28,17 +28,9 @@ Add as many details as possible to help others reproduce the issue and test the Both the PR author and reviewer are responsible for ensuring the checklist is completed. --> - [ ] PR title and description contain sufficient detail and accurately describe the changes -- [ ] Acceptance criteria is met -- [ ] Decisions are publicly documented - [ ] Adheres to coding standards ([PHP](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/), [JavaScript](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/), [CSS](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/), [HTML](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/html/)) - [ ] All strings are translatable (without concatenation, handles plurals) - [ ] Follows our naming conventions (P6rkRX-4oA-p2) - [ ] Hooks (p6rkRX-1uS-p2) and functions are documented - [ ] New UIs are responsive and use a [mobile-first approach](https://zellwk.com/blog/how-to-write-mobile-first-css/) -- [ ] New UIs match the designs -- [ ] Different user privileges (admin, teacher, subscriber) are tested as appropriate -- [ ] Legacy courses (course without blocks) are tested - [ ] Code is tested on the minimum supported PHP and WordPress versions -- [ ] User interface changes have been tested on the latest versions of Chrome, Firefox and Safari -- [ ] "Needs Documentation" label is added if this change requires updates to documentation -- [ ] Known issues are created as new GitHub issues