Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all new Course and Lesson patterns #5136

Closed
alexsanford opened this issue May 16, 2022 · 4 comments · Fixed by #5206
Closed

Implement all new Course and Lesson patterns #5136

alexsanford opened this issue May 16, 2022 · 4 comments · Fixed by #5206
Assignees
@renatho
Milestone
4.5.0 - Course an...

Comments

@alexsanford
Copy link
Contributor

No description provided.

@alexsanford alexsanford added this to the Course and Lesson Wizard milestone May 16, 2022
@renatho renatho mentioned this issue May 24, 2022
Merged
@renatho
Copy link
Contributor

renatho commented May 24, 2022

Just a comment that we could re-think here if we want to have the quiz block in the default template or not. More details: #5138 and #5177

@renatho
Copy link
Contributor

renatho commented May 26, 2022

Another thing that we could fix as part of this issue, is the styles of the blocks in the pattern preview.

In the Course Outline block, for example, we have some styles under .block-editor specificity, which don't apply to the preview, and so the styles doesn't look good.

Screen Shot 2022-05-26 at 11 20 12

@renatho
Copy link
Contributor

renatho commented May 30, 2022

See also an issue with the thumbnail height that we need to check if it will happen with the final patterns: #5202 (review) / #5173 (under known issues).

@renatho renatho mentioned this issue May 30, 2022
Merged
@renatho
Copy link
Contributor

renatho commented May 30, 2022 •
edited
Loading

The patterns to be added: p1653927378058799-slack-C8QJAM52B

@renatho renatho self-assigned this May 30, 2022
@renatho renatho mentioned this issue May 30, 2022
Merged
@renatho renatho changed the title Implement all new Course and Lesson patterns (designs pending) Implement all new Course and Lesson patterns May 30, 2022
@renatho renatho mentioned this issue Jun 1, 2022
Closed
@renatho renatho closed this as completed Jun 2, 2022
@fjorgemota fjorgemota linked a pull request Jun 2, 2022 that will close this issue
Add new sensei patterns and separate block patterns logic #5206
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renatho renatho

Labels
None yet
Projects
None yet
Milestone
4.5.0 - Course and Lesson Wizard
Development

Successfully merging a pull request may close this issue.

Add new sensei patterns and separate block patterns logic Automattic/sensei
2 participants
@alexsanford @renatho