From 8cfaa215006112a14a93a07b33cc010883dfc26b Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Mon, 1 Jul 2024 16:52:37 -0300 Subject: [PATCH 1/3] SPAppDelegate+Extensions: Drops whitespaces --- Simplenote/SPAppDelegate+Extensions.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Simplenote/SPAppDelegate+Extensions.swift b/Simplenote/SPAppDelegate+Extensions.swift index 4e19255b3..151fc1c60 100644 --- a/Simplenote/SPAppDelegate+Extensions.swift +++ b/Simplenote/SPAppDelegate+Extensions.swift @@ -452,13 +452,13 @@ extension SPAppDelegate { func performMagicLinkAuthentication(with url: URL) -> Bool { MagicLinkAuthenticator(authenticator: simperium.authenticator).handle(url: url) } - + @objc(performMagicLinkAuthenticationWithUserActivity:) func performMagicLinkAuthentication(with userActivity: NSUserActivity) -> Bool { guard let url = userActivity.webpageURL else { return false } - + return performMagicLinkAuthentication(with: url) } } From 812d62298603f0e2539d71ccac15f04b50d98320 Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Mon, 1 Jul 2024 16:55:37 -0300 Subject: [PATCH 2/3] Updates Linter Rules --- .swiftlint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.swiftlint.yml b/.swiftlint.yml index cf03a5a91..0826295f6 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -42,9 +42,9 @@ only_rules: - trailing_semicolon # Lines should not have trailing whitespace. - - trailing_whitespace +# - trailing_whitespace - - vertical_whitespace +# - vertical_whitespace - custom_rules From 59f95421a065292f37ae41a4a975fbdb6d3b1668 Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Mon, 1 Jul 2024 17:06:35 -0300 Subject: [PATCH 3/3] Fixes UI Tests --- SimplenoteUITests/EmailLogin.swift | 1 + SimplenoteUITests/UIDs.swift | 1 + 2 files changed, 2 insertions(+) diff --git a/SimplenoteUITests/EmailLogin.swift b/SimplenoteUITests/EmailLogin.swift index 6fae2609a..22041a7f6 100644 --- a/SimplenoteUITests/EmailLogin.swift +++ b/SimplenoteUITests/EmailLogin.swift @@ -34,6 +34,7 @@ class EmailLogin { class func logIn(email: String, password: String) { enterEmail(enteredValue: email) + app.buttons[UID.Button.continueWithPassword].tap() enterPassword(enteredValue: password) app.buttons[UID.Button.logIn].tap() handleSavePasswordPrompt() diff --git a/SimplenoteUITests/UIDs.swift b/SimplenoteUITests/UIDs.swift index 65ae52e39..e47813a04 100644 --- a/SimplenoteUITests/UIDs.swift +++ b/SimplenoteUITests/UIDs.swift @@ -26,6 +26,7 @@ enum UID { static let menu = "menu" static let signUp = "Sign Up" static let logIn = "Log In" + static let continueWithPassword = "Continue with Password" static let logInWithEmail = "Log in with email" static let allNotes = "All Notes" static let trash = "Trash"