Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests can't run on CI #1536

Closed
crazytonyli opened this issue Nov 1, 2023 · 6 comments
Closed

UI tests can't run on CI #1536

crazytonyli opened this issue Nov 1, 2023 · 6 comments
Labels
bug Something isn't working.

Comments

@crazytonyli
Copy link
Contributor

The UI tests CI step is failing because fastlane fails to find the test accounts which are stored in kvdb.io.

@crazytonyli crazytonyli added the bug Something isn't working. label Nov 1, 2023
@peril-automattic
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

1 similar comment
@peril-automattic
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@pachlava
Copy link
Contributor

pachlava commented Nov 2, 2023

@crazytonyli 👋

The free variant of buckets on kvdb.io lasts for 3 months IINM. To restore the bucket, it's enough to run one command from terminal: p1667903243007039/1658172902.518279-slack-C02H2SVA1L5

I just did that, and the testing PR #1537 started executing the tests. All of them failed, however 😆, which is a good sign, because most probably the reason is the same for all. I'll have a look at the reason later this week, but I think the current issue can be closed.

P.S. Given the repo activity level, I don't think it makes sense to pay for the bucket. When the repo was active, the selection of test accounts was really needed, to avoid race scenarios, because the tests hit the real API. Now, I think we can either stick to running this command every 3 months or even get back to using one test account. WDYT?

@crazytonyli
Copy link
Contributor Author

@pachlava Thanks for looking into this issue.

Do you think we can put the UI_TESTS_ACCOUNTS_JSON_URL content into the pipeline's secret file? So that we don't need to go through kvdb.io?

@pachlava
Copy link
Contributor

pachlava commented Nov 3, 2023

@crazytonyli, I think it's a matter of scope / visibility. This should be an environment variable which can be read/written by different builds simultaneously. AFAIK, this was hard to achieve when CircleCI was in use. Possibly with BK this is easier?

@charliescheer
Copy link
Contributor

I brought this issue up recently cause we are cleaning up the SNiOS repo right now, and the CI failing got noticed. @spencertransier got the CI running again. Gonna close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

3 participants