New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use share as tab name for previews #926

Closed

sejas wants to merge 1 commit into trunk from update/rename-preview-tab-to-share

Member

sejas commented Feb 12, 2025 •

edited

Loading

Related issues

Related to p58i-jjs-p2#comment-66306

Proposed Changes

I think using Share is easier for users to understand what's the tab for.
It's also easier to translate to other languages like Spanish

Testing Instructions

Observe the new tab says Share and it contains the previews table.

Before

Screenshot 2025-02-12 at 14 32 00

Screenshot 2025-02-12 at 14 40 40

After

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?


          Use share as tab name for previews

30904ce

sejas self-assigned this

sejas requested a review from a team

February 12, 2025 14:39

Member Author

sejas commented Feb 12, 2025

Let's stick with Previews so we avoid confusion with Sync tab, and receive feedback in CfT.
Slack p1739371912108429-slack-C04GESRBWKW

sejas closed this

sejas deleted the update/rename-preview-tab-to-share branch

February 12, 2025 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet