-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alves: Footer Credit Migrates To The Middle Of Page #2976
Comments
This appears to be happening on the Doyle starter design site (and existing sites' homepages based on that design), and when the Doyle design is previewed via wordpress.com/new (the Doyle design uses the Alves theme): Note that the cover block is also stretched too high vertically on the front end of the site: Raised in p1609974704240000/1609962160.232600-slack-C013QHLF28Y |
In the interim, we've hidden the Doyle design in Gutenboarding to hide that design for new sites. Once there's a fix for this bug, we can revert Automattic/wp-calypso#48723 and make the design available again. |
I believe the cover block height issue + migration of the footer credit to the middle of the page should be resolved once the above Gutenberg PR lands on wpcom. |
The issue is still present since the above Gutenberg PR was reverted. New PR here: WordPress/gutenberg#28455 🤞 hopefully the above can land soon and we can close this. |
I verified that the underlying cover block height issue was fixed in Gutenberg and now lives on dotcom. @andrewserong you should be able to reactivate Doyle. Thanks! |
Thanks @jffng I've opened a revert to reactivate Doyle in Automattic/wp-calypso#49801 |
Steps to replicate
Video: https://d.pr/v/08u8yG
Result
The theme's footer credit migrates from the bottom of the page to the second block.
Video: https://d.pr/v/v7iwnG
When Group and Layout Grid Blocks are not used on a page (so just using a Cover Block and Media/Text Block on the page), the footer credit stays at the bottom of the page.
Expected
The footer credit to remain at the bottom of the page. CSS can "fix" this by hiding the credit but that isn't ideal especially on the user's current plan.
The text was updated successfully, but these errors were encountered: