Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alves: Footer Credit Migrates To The Middle Of Page #2976

Closed
synora opened this issue Jan 6, 2021 · 6 comments
Closed

Alves: Footer Credit Migrates To The Middle Of Page #2976

synora opened this issue Jan 6, 2021 · 6 comments
Assignees
Labels
[Theme] Varia [Type] Bug Something isn't working

Comments

@synora
Copy link

synora commented Jan 6, 2021

Steps to replicate

  1. Create a new page with a blank template.
  2. Add a Group Block
  3. Add a 1 Column Layout Grid Block with the following settings: https://d.pr/i/YbpRCD
  4. Add 2 blocks within the Layout Grid block: a Cover Block, then a Media And Text Block with content (order of which block is added first doesn't matter).
    Video: https://d.pr/v/08u8yG
  5. Publish the page and mark it as your homepage in Design > Customize > Homepage Settings. Choose "Select" for the posts page.
  6. View the homepage.

Result

The theme's footer credit migrates from the bottom of the page to the second block.
Video: https://d.pr/v/v7iwnG

When Group and Layout Grid Blocks are not used on a page (so just using a Cover Block and Media/Text Block on the page), the footer credit stays at the bottom of the page.

Expected

The footer credit to remain at the bottom of the page. CSS can "fix" this by hiding the credit but that isn't ideal especially on the user's current plan.

  • User report: #26825302-hc
  • Follow-up ticket: #3627711-zd
@andrewserong andrewserong added the [Type] Bug Something isn't working label Jan 7, 2021
@andrewserong
Copy link
Member

andrewserong commented Jan 7, 2021

This appears to be happening on the Doyle starter design site (and existing sites' homepages based on that design), and when the Doyle design is previewed via wordpress.com/new (the Doyle design uses the Alves theme):

image

Note that the cover block is also stretched too high vertically on the front end of the site:

doyle-issue-small

Raised in p1609974704240000/1609962160.232600-slack-C013QHLF28Y

@andrewserong
Copy link
Member

In the interim, we've hidden the Doyle design in Gutenboarding to hide that design for new sites. Once there's a fix for this bug, we can revert Automattic/wp-calypso#48723 and make the design available again.

@jffng
Copy link
Contributor

jffng commented Jan 12, 2021

I believe the cover block height issue + migration of the footer credit to the middle of the page should be resolved once the above Gutenberg PR lands on wpcom.

@jffng
Copy link
Contributor

jffng commented Jan 26, 2021

The issue is still present since the above Gutenberg PR was reverted. New PR here: WordPress/gutenberg#28455

🤞 hopefully the above can land soon and we can close this.

@jffng
Copy link
Contributor

jffng commented Feb 5, 2021

I verified that the underlying cover block height issue was fixed in Gutenberg and now lives on dotcom. @andrewserong you should be able to reactivate Doyle.

Thanks!

@andrewserong
Copy link
Member

Thanks @jffng I've opened a revert to reactivate Doyle in Automattic/wp-calypso#49801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Varia [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants