Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating all block themes to use new layout setting #6477

Open
mikachan opened this issue Aug 30, 2022 · 3 comments
Open

Consider updating all block themes to use new layout setting #6477

mikachan opened this issue Aug 30, 2022 · 3 comments
Labels
Needs triage [Type] Bug Something isn't working

Comments

@mikachan
Copy link
Member

Quick summary

Now that WordPress/gutenberg#42763 has been merged, we should consider updating all block themes to use the new layout setting.

The templates should be updated to use the new layout setting for container blocks:

  • "layout":{"type":"constrained"}: Inner blocks have wide and full width options. Replaces layout":{"inherit":true}
  • "layout":{"type":"default"}: inner blocks do not have wide and full width options. Replaces layout":{"inherit":false}

I don't believe this is a breaking change, but it would be nice to use the correct, up-to-date settings.

Steps to reproduce

n/a

What you expected to happen

n/a

What actually happened

n/a

Browser

No response

Context

No response

Platform (Simple, Atomic, or both?)

No response

Other notes

No response

Reproducibility

Consistent

Severity

No response

Available workarounds?

No response

Workaround details

No response

@mikachan mikachan added [Type] Bug Something isn't working Needs triage labels Aug 30, 2022
@pbking
Copy link
Contributor

pbking commented Aug 30, 2022

How long would the "old format" be supported? Does leaving older themes alone make sense?

Does changing the configuration change the user experience in any way?

This would have to be a post-6.1 change right?

If the above checks out I suggest instead we target specific themes (Block Canvas for sure, Blockbase, and perhaps any theme made in the last couple of months).

@mikachan
Copy link
Member Author

mikachan commented Sep 1, 2022

I think it's good practice for us to keep all our block themes up to date, but I realise this is a lot of maintenance, especially with the speed of Gutenberg changes. Updating Block Canvas as a priority sounds good to me.

I don't believe the configuration changes the end-user experience, and as far as I know it's backward compatible.

Yes, this would need to be post-6.1 (this change was in GB 14).

@cwebba1
Copy link

cwebba1 commented Apr 17, 2023

I am working on my posts page. Using 6.2 WordPress. There is a gap between the post title and the post excerpt that seems to come from body .is-layout-constrained > * + * {} and/or body .is-layout-constrained > * {}. They are causing margin-block-start and margin-block-end declarations,
Where and how can I turn off these horrid declarations?
They are set at 24px and they are ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants