Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Themes: Transition Headstart Content to Pattern + Move to template #6758

Open
11 tasks
pbking opened this issue Dec 1, 2022 · 1 comment
Open
11 tasks

Comments

@pbking
Copy link
Contributor

pbking commented Dec 1, 2022

As a part of the work to make theme defaults more consistent (pNEWy-fG8-p2), we'd like to remove a lot of the configuration done by headstart.

In going through this process, we found home page designs for many themes that are only provided via Headstart annotations. Calvin, for example:

image

By default, the theme is configured by headstart to generate this content in a page assigned to a custom template — header-footer-only or footer-only template — and the site's reading settings adjusted to display this page. If we were to remove this configuration from headstart, the theme would not match the expectation of the demo site with no way to provide this design to the user.

So, to remove headstart configurations while still achieving the design intent of the theme, there are a couple options:

  1. Add the content to a default template (such as index.html or home.html), via a pattern or directly to the template. This could break existing sites by overriding their existing template structure.
  2. Alternatively, create a new theme (such as Calvin-2) with the templates configured as desired, retire the previous version.

The following themes are affected by this situation:

  • Calvin
  • Ames
  • Farrow
  • Hari
  • Heiwa
  • Dorna
  • Appleton
  • Meraki
  • Antonia
  • Appleton
  • Quadrat

cc @ianstewart

@pbking pbking changed the title Calvin: Transition Headstart Content to Pattern Multiple Themes: Transition Headstart Content to Pattern + Move to template Dec 1, 2022
@mikachan
Copy link
Member

mikachan commented Dec 2, 2022

I think Quadrat can be added to this list too.

@ianstewart ianstewart mentioned this issue Dec 14, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants