Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Tall drop down menus overflow the container and are clipped #7844

Closed
mrfoxtalbot opened this issue Jun 4, 2024 · 3 comments
Closed
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal Triaged [Type] Bug Something isn't working

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jun 4, 2024

Quick summary

The main menu is nested inside a cover block that is site as overflow:hidden.

If enough drop-down menus are added to the main menu, they will overflow and become invisible & unreachable.

Here's a video:

Kapture.2024-06-04.at.11.10.28.mp4

Adding this CSS fixes the issue (but it might be too generic and affect cover blocks elsewhere). Perhaps we could use .wp-site-blocks > .wp-block-cover:has(.wp-block-navigation__submenu-container) to increase specificity:

.wp-site-blocks > .wp-block-cover {
  overflow:visible 
}

After adding this code, the dropdown is no longer constrained by the cover block's height:
Screenshot 2024-06-04 at 11 13 13

Context: 8268355-zd-a8c

Steps to reproduce

  1. Activate Assembler
  2. Set up a header that includes a cover.
  3. Add enough items to a submenu to make it overflow.

What you expected to happen

All items should remain visible.

What actually happened

Submenu items were clipped.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8268355-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jun 4, 2024
@rickmgithub
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  1. Install the Assembler theme on an AT site
  2. Add a cover block to the header and insert an image
  3. Then add a menu into the cover block
  4. Add items in a submenu so they appear as a drop down. You need to add enough items that it stretches over the bottom of the cover block
  5. Notice how the menu is clipped.

Screenshare
https://github.com/Automattic/themes/assets/13706336/42a01528-0221-4d7b-8489-f91fa4036430

📌 ACTIONS

Triaged

@richtabor
Copy link
Contributor

richtabor commented Nov 11, 2024

I'm marking this as a duplicate of WordPress/gutenberg#45353. This is not Assembler-related.

Also reported via Calypso here.

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal Triaged [Type] Bug Something isn't working
Development

No branches or pull requests

3 participants