Quadrat: comment form style tweaks #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
force-pushed
the
comments-tweaks
branch
from
7ba60cb to
72b4df0
Compare
|
I rebased this with the latest button changes and updated the screenshot with the latest changes too. |
MaggieCabrera
force-pushed
the
comments-tweaks
branch
from
72b4df0 to
d97042d
Compare
|
I just updated this with Bea's comments from #3898 This is ready for another review. |
danieldudzic
suggested changes
May 24, 2021
There was a problem hiding this comment.
This looks mostly fine.
If I have understood correctly, @beafialho has suggested that the comment text and button have the same font-size. At the moment there's still a slight discrepancy:
Also nested comments don't seem to be working - but I don't know if that's something we want to support (?)
|
@danieldudzic I fixed the font size of the buttons. I do see the nested comments though:
|
|
Font sizes and buttons styles all look 👍 LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR styles the comments block to reflect the changes from #3898
Related issue(s):
Closes #3898