Luminance: Fix display of featured images #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The featured images in Luminance were completely misaligned due to changes in how Gutenberg has changed the specifity of style rules. Rather than the custom block-specific CSS for the core/featured-image block taking priority, the default block library styles did. The problem has been reported upstream (WordPress/gutenberg#64453) but in the meantime, using the theme-wide custom CSS fixes the problem.
Preview changesI've detected changes to the following themes in this PR: Luminance. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
This does work for me! Closing as fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The featured images in Luminance were completely misaligned due to changes in how Gutenberg handles specificity of style rules. Rather than the custom block-specific CSS for the
core/featured-imageblock taking priority, the default block library styles do.The problem has been reported upstream but in the meantime, using the theme-wide custom CSS fixes the problem.
(ignore the devtools in the screenshots)
Related issue(s):