-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make the help text for the format
option consistent for all commands
#2129
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
138eacb
to
046ce18
Compare
@sjinks This is amazing! Thank you! I tested this branch locally, and have a couple questions after looking at the
|
Quality Gate passedIssues Measures |
No, it's the wrong file. I need more sleep :-) I intended to remove it from the VIP app. Fixed, thanks!
Wrong command; it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works perfectly. Thank you so much for making this change! I think this is a huge improvement for the help menu.
Description
As discussed, this PR changes the help text for the
--format
option toAffected commands:
vip app list
vip config envvar get-all
vip config software get
vip config envvar list
vip logs
(atext
option is added to the list)vip slowlogs
vip validate preflight
Pull request checklist
New release checklist
Steps to Test
Run the mentioned commands and make sure they still work.