-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom deploy zip file size limitation #2133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, adm-zip does not support files bigger than 2GB (cthackers/adm-zip#334). To fix it, the ZIP library was replaced by node-stream-zip, which supports files bigger than 2GB.
Dependency ReviewThe following issues were found:
OpenSSF Scorecard
Scanned Files
|
luismulinari
changed the title
Replce adm-zip by node-stream-zip
Fix custom deploy zip file size limitation
Dec 2, 2024
luismulinari
force-pushed
the
replace-admzip-by-node-stream-zip
branch
from
December 2, 2024 19:59
4ff57be
to
7a590e1
Compare
luismulinari
force-pushed
the
replace-admzip-by-node-stream-zip
branch
from
December 2, 2024 20:01
7a590e1
to
6ccf597
Compare
Tested and works good, we should look at why the tests are failing though. |
luismulinari
force-pushed
the
replace-admzip-by-node-stream-zip
branch
from
December 2, 2024 22:56
c207eb8
to
e97a9e1
Compare
luismulinari
force-pushed
the
replace-admzip-by-node-stream-zip
branch
from
December 3, 2024 13:19
89f8d8d
to
2a12396
Compare
Quality Gate passedIssues Measures |
rebeccahum
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the
adm-zip
library withnode-stream-zip
to address a critical limitation:adm-zip
does not support processing files larger than 2GB (cthackers/adm-zip#334). As a result, our custom deploy validation fails when handling large zip files. The new library,node-stream-zip
, provides robust support for large archives and offers a more efficient, stream-based approach to working with zip files.Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build
node ./dist/bin/vip-app-deploy-validate.js /tmp/valid-zip.zip