Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev-env): let dev-tools handle their volumes #2139

Merged
merged 2 commits into from
Dec 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: set dependencies between services
  • Loading branch information
sjinks committed Dec 12, 2024
commit f77bded836de077cb54b6ff8b0e9405a736c8dde
23 changes: 14 additions & 9 deletions assets/dev-env.lando.template.yml.ejs
Original file line number Diff line number Diff line change
@@ -22,10 +22,6 @@ services:
volumes:
- devtools:/dev-tools
- scripts:/scripts
environment:
LANDO_NO_USER_PERMS: 1
LANDO_NO_SCRIPTS: 1
LANDO_NEEDS_EXEC: 1
volumes:
devtools: {}
scripts:
@@ -38,14 +34,13 @@ services:
sslExpose: false
services:
image: ghcr.io/automattic/vip-container-images/nginx:latest
command: nginx -g "daemon off;"
environment:
LANDO_NEEDS_EXEC: 1
LANDO_WEBROOT_USER: nginx
LANDO_WEBROOT_GROUP: nginx
volumes:
- ./nginx/extra.conf:/etc/nginx/conf.extra/extra.conf
<% wpVolumes() %>
depends_on:
php:
condition: service_started
entrypoint: /usr/sbin/nginx -g "daemon off;"

php:
type: compose
@@ -77,6 +72,16 @@ services:
<% } %>
devtools:
condition: service_completed_successfully
wordpress:
condition: service_started
<% if ( muPlugins.mode == 'image' ) { %>
vip-mu-plugins:
condition: service_started
<% } %>
<% if ( appCode.mode == 'image' ) { %>
demo-app-code:
condition: service_completed_successfully
<% } %>
volumes:
- type: volume
source: devtools
Loading