Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping / and :: in endpoint URLs #44

Open
nylen opened this issue Nov 15, 2016 · 0 comments
Open

Escaping / and :: in endpoint URLs #44

nylen opened this issue Nov 15, 2016 · 0 comments

Comments

@nylen
Copy link
Contributor

nylen commented Nov 15, 2016

I tested out Jetpack sites installed into subdomains. In the existing (old) console it is pretty badly broken, but it is mostly working correctly here.

Test cases

v1 API; enter make.wordpress.org/core into site field

image

This does not work - it sends a request to v1.1/sites/make.wordpress.org/core/posts/ which is a 404 of course.

v1 API; enter make.wordpress.org%2Fcore into site field

This works correctly.

v1 API; enter make.wordpress.org/core into URL directly

image

This does not work, and we shouldn't expect it to work. There's no reliable way to tell that this is a URL for the /posts endpoint.

v1 API; enter make.wordpress.org%2Fcore into URL directly

This works correctly.

v1 API; enter make.wordpress.org::core into site field or into URL directly

This is sent to the server correctly, but the v1 API does not support it.

v2 API; enter make.wordpress.org/core or make.wordpress.org%2Fcore

This is sent to the server in the same way as the v1 API, but the v2 API does not support it.

v2 API; enter make.wordpress.org::core into site field or into URL directly

This works correctly.

Potential improvements

  1. If / is entered into a site URL field, transform it into %2F
  2. If :: is entered for the v1 API, transform it into %2F
  3. If / or %2F are entered for the v2 API, transform it into ::
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant