Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Resolve some duplicate dependencies #27905

Closed
4 tasks done
blowery opened this issue Oct 17, 2018 · 4 comments
Closed
4 tasks done

Gutenberg: Resolve some duplicate dependencies #27905

blowery opened this issue Oct 17, 2018 · 4 comments

Comments

@blowery
Copy link
Contributor

blowery commented Oct 17, 2018

We have some package level dupes do to version pinning:

WARNING in clipboard
  Multiple versions of clipboard found:
    1.7.1 ./~/@wordpress/components/~/clipboard
    2.0.1 ./~/clipboard

WARNING in jquery
  Multiple versions of jquery found:
    1.12.3 ./~/jquery
    3.3.1 ./~/@wordpress/editor/~/jquery

WARNING in moment-timezone
  Multiple versions of moment-timezone found:
    0.5.11 ./~/i18n-calypso/~/moment-timezone
    0.5.21 ./~/moment-timezone

WARNING in react-click-outside
  Multiple versions of react-click-outside found:
    2.3.1 ./~/@wordpress/components/~/react-click-outside
    3.0.1 ./~/react-click-outside

To resolve

@blowery
Copy link
Contributor Author

blowery commented Oct 17, 2018

#27823 addresses the moment-timezone dupe

@blowery
Copy link
Contributor Author

blowery commented Oct 17, 2018

jquery I think we're just leaving alone since we already extern jQuery@1.12 and bundle jQuery@3. #27778 dealt with it.

@dmsnell dmsnell assigned dmsnell and unassigned dmsnell Oct 18, 2018
@blowery
Copy link
Contributor Author

blowery commented Oct 18, 2018

WordPress/gutenberg#10748 and WordPress/gutenberg#10739 filed with Gutenberg to get them up to a range that matches us (and on current versions)

@blowery
Copy link
Contributor Author

blowery commented Nov 14, 2018

All dupes from gutenberg are now deduped.

@blowery blowery closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants