Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg on wpcom: fix mobile/tablet/desktop previews #40401

Open
simison opened this issue Mar 24, 2020 · 4 comments
Open

Gutenberg on wpcom: fix mobile/tablet/desktop previews #40401

simison opened this issue Mar 24, 2020 · 4 comments
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Goal] New Onboarding previously called Gutenboarding [Type] Task

Comments

@simison
Copy link
Member

simison commented Mar 24, 2020

In #40388 we disabled the new "preview" functionality in Gutenberg 7.7.1:

image

Instead, we have just:

image

TODO:

@simison simison added [Type] Task [Goal] Gutenberg Working towards full integration with Gutenberg [Goal] New Onboarding previously called Gutenboarding labels Mar 24, 2020
@simison
Copy link
Member Author

simison commented Mar 25, 2020

Once we fix this and enable the feature on wpcom again, we can enable these changes to E2E tests I just removed again: 5d9870d

@roo2
Copy link
Contributor

roo2 commented Mar 27, 2020

Our current understanding of what's happening:

Mobile/tablet preview uses the use-simulated-media-query function which works by modifying the loaded stylesheets to simulate being viewed on mobile/tablet breakpoints.

This works for stylesheets loaded from the same domain. However, on wordpress.com, the static domains s0.wp.com and s1.wp.com are used to serve many stylesheets such as those from the full-site-editing-plugin.

These stylesheets are therefore rendered in desktop mode even when using mobile/tablet preview.

more context: p7DVsv-8gl-p2#comment-27501

@roo2
Copy link
Contributor

roo2 commented Mar 27, 2020

creted Gutenberg issue WordPress/gutenberg#21193

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Goal] New Onboarding previously called Gutenboarding [Type] Task
Projects
None yet
Development

No branches or pull requests

2 participants