Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Drop ClientSideEffects, use PageViewTracker instead #4566

Closed
ockham opened this issue Apr 7, 2016 · 0 comments · Fixed by #6005
Closed

Framework: Drop ClientSideEffects, use PageViewTracker instead #4566

ockham opened this issue Apr 7, 2016 · 0 comments · Fixed by #6005
Assignees
@ockham
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Framework [Type] Task
Milestone
Themes: Showcase ...

Comments

@ockham
Copy link
Contributor

ockham commented Apr 7, 2016

Both have overlapping concerns. While ClientSideEffects is more generic, there hasn't yet been any other use case than page views, so let's use the more specialized component and drop the generic one. (See #4332 for some discussion on that.) Redundancies == bad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ockham ockham

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Framework [Type] Task
Projects
None yet
Milestone
Themes: Showcase M4-ThemeSheets
Development

Successfully merging a pull request may close this issue.

Themes: Use PageViewTracker, drop ClientSideEffects Automattic/wp-calypso
1 participant
@ockham