Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show proper icon in current Site #45965

Closed
cpapazoglou opened this issue Sep 28, 2020 · 2 comments
Closed

Show proper icon in current Site #45965

cpapazoglou opened this issue Sep 28, 2020 · 2 comments
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@cpapazoglou
Copy link
Contributor

In the scope of unifying the navigation between calypso and wp-admin we have to make sure that we show a proper icon when:

  1. site has no favicon
  2. site has favicon

The UI should match between calypso, wp-admin and the designs
https://www.figma.com/file/9cy0DIowQkPAu0rodb9jsL/WP-Admin-for-Dotcom?node-id=343%3A986&viewport=-5836%2C1756%2C1.047106385231018

Current calypso screenshot
@cpapazoglou cpapazoglou added [Type] Task [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Sep 28, 2020
@cpapazoglou cpapazoglou mentioned this issue Sep 29, 2020
Closed
94 tasks
@obenland
Copy link
Member

Fix in D50388-code

@obenland obenland added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 29, 2020
@cpapazoglou
Copy link
Contributor Author

Deployed r214444-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obenland @cpapazoglou