Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification: Check domain notices #46732

Closed
sixhours opened this issue Oct 23, 2020 · 1 comment · Fixed by #46819
Closed

Nav Unification: Check domain notices #46732

sixhours opened this issue Oct 23, 2020 · 1 comment · Fixed by #46819
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. Navigation [Team] AJAX [Type] Task

Comments

@sixhours
Copy link
Contributor

Steps to reproduce

  • Starting at URL: /home/[your-site]/?flag=nav-unification
  • On a site with an expired domain, you'll see something like this:

Screen Shot 2020-10-23 at 10 52 27 AM

There are other non-JITM notices that pop up here that probably need testing. I usually trigger them by overriding the logic in that file manually; not sure if there's a better way.

@sixhours sixhours added Navigation [Team] AJAX [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Oct 23, 2020
@cpapazoglou cpapazoglou self-assigned this Oct 27, 2020
@cpapazoglou
Copy link
Contributor

@sixhours interesting enough, the text is overflowing in production already! It is just the fact that the overflowing content is hidden

and it is more prominent now due to the narrower sidebar.

Addressed here #46819. I would appreciate it if you could take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. Navigation [Team] AJAX [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants