Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-texturize menu titles before sending them through the API #18087

Closed
cpapazoglou opened this issue Oct 28, 2020 · 1 comment · Fixed by #18088
Closed

Un-texturize menu titles before sending them through the API #18087

cpapazoglou opened this issue Oct 28, 2020 · 1 comment · Fixed by #18088
Assignees
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations

Comments

@cpapazoglou
Copy link
Contributor

cpapazoglou commented Oct 28, 2020

Steps to reproduce

  1. Starting at URL: http://calypso.localhost:3000/home/[domain]?flags=nav-unification on a site without the blog sticker

image

What I expected

In Comments I've made

What happened instead

In Comments I’ve made

Since the comments menu will not be available in the new nav-unification menu it doesn't make sense fixing directly this. It makes sense though to account for any third party plugins registered which may use '. That said, we can explore not passing through wptexturize() all the menu titles before serving them in class-admin-menu.php

@marekhrabe
Copy link
Contributor

We’ll just have to remove the wp_texturize() calls in the API endpoint 😉
—Obenland, 2020

@obenland obenland self-assigned this Dec 14, 2020
@obenland obenland changed the title Texturize menu titles before sending them through the API Un-texturize menu titles before sending them through the API Dec 14, 2020
@obenland obenland transferred this issue from Automattic/wp-calypso Dec 14, 2020
@jeherve jeherve added the [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants