Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: community translator is broken #6139

Closed
yoavf opened this issue Jun 19, 2016 · 0 comments
Closed

i18n: community translator is broken #6139

yoavf opened this issue Jun 19, 2016 · 0 comments

Comments

@yoavf
Copy link
Contributor

yoavf commented Jun 19, 2016

Since the upgrade to react 15.1 #5116, the value attribute isn't being passed to the data element wrapping translations, once the community translator has been activated. This causes the translator to fail processing the strings, as it expects the original string to be in the value attribute.

Seems like this is due to a known regression in React 15- which seems to have been fixed specifically for input/textarea tags in facebook/react#6406

I haven't been able to confirm this, but I don't think the fix above will help with data elements.
A workaround would be to use a data-value attribute (or similar), and update the community translator accordingly.

Repro:

  • Set UI locale to not-English
  • Enable the community translator
  • Activate the community translator
  • Notice strings not being translatable (properly highlighted) + console errors.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant