-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old Cover Blocks with Fixed Backgrounds are now showing greatly enlarged backgrounds. #65042
Comments
Another instance here: 5329926-zen Kindly follow up here:
|
This customer was promised to be updated when this bug is fixed.
|
Another case here 35947281-hc Kindly follow up here:
|
Another instance here: 5325449-zen Kindly Follow-up here:
|
Another instance here: 5339064-zen Kindly Follow-up here:
|
Another instance here: 5342352-zd-woothemes |
|
|
📌 SCRUBBING
📌 FINDINGS/SCREENSHOTS/VIDEO
For tests, I started by copying over cover blocks from the OP's site. Cover blocks zoomed in on the image in all testing environments, as well as on new cover blocks added today. AT Screen.Capture.on.2022-07-12.at.09-26-38.mp4Self-Hosted Screen.Capture.on.2022-07-12.at.09-33-50.mp4Simple P2 Screen.Capture.on.2022-07-12.at.09-36-03.mp4Image Dimensions 📌 Workaround
I resized the OP user's Screen.Capture.on.2022-07-12.at.09-46-57.mov📌 ACTIONS
|
Hi hi! I don't have access to the various zendesk tickets and am not sure what p2 is being referenced since nothing is linked. The Cover block had some style changes in 5.9 (wouldn't impact this) and can now use a featured image in 6.0 (again wouldn't impact this afaik) so I'm not quite sure what's different here. I did try various sized images using WordPress 6.0.1 and wasn't able to notice anything super odd: Screen.Recording.2022-07-12.at.11.59.59.AM.movWhen I try with WordPress 6.0.1 and Gutenberg 13.6, I do notice a few oddities that I think make sense to report in the Gutenberg repo: Screen.Recording.2022-07-12.at.12.01.22.PM.movSpecifically, the largest image size zooms in more whereas the smallest ends up as a pattern! @cuemarie can you handle following up on this please? |
The customers coming in are specifically saying that it looks different than previously. It used to be much less zoomed in. |
Definitely think an issue in Gutenberg's GitHub repo needs to be opened with examples, clear ways to reproduce, etc. |
@annezazu If it's only an issue happening with previously-created old cover blocks, would it make sense to just grab the affected code and work with that? |
Yes! That would be very helpful to cross compare to see what might be at the root of this. Specifically, examples along with timeframes of when this changed would go a long way. |
To be safe/to not lose more time, I went ahead and opened an issue in the Gutenberg repo: WordPress/gutenberg#42407 As a reminder, I cannot see the zendesk tickets so if folks can share examples of the block markup impacted by this issue in the Gutenberg one, that would be very helpful! |
Another instance here: 34135037-hc User requested to be notified if/when it's fixed. |
Support References This comment is automatically generated. Please do not edit it.
|
Another one: 5401674-zd-woothemes |
@annezazu Coming back to this after some time away from guild work, thank you for pushing forward with the Gutenberg issue! Is this the kind of code that's helpful? Here's the full copiable code from the OP's cover block, I've just swapped the Image URLs with a free Pexels photo:
I'll share on the Gutenberg issue as well. |
Update for HEs - A fix is in the works here: WordPress/gutenberg#42470 . Gutenberg updates are released every 2 weeks (rolling out on WordPress.com sites shortly after that), so once this fix is confirmed (not quite there yet as of this comment), it'll be another two weeks or so for the solution to take effect on WordPress.com sites. In the meantime, if you'd like to offer a CSS workaround, you can address the issue on individual sites frontend display by adding the following custom CSS (Thanks @glendaviesnz on WordPress/gutenberg#42407 for this!):
|
@cuemarie Thanks for sharing! That is helpful. No more examples needed at this point since a fix is in the works. |
Copy that, @annezazu ! For HEs that encounter users who want an update when this one is fixed, we've queued this up for batch replies when the time comes, so feel free to share any other tickets that need a follow up. Formatting reminders: p7DVsv-eD3-p2 |
Another one: 5382860-zd-woothemes |
@alliebbush2 shared a CSS in 5408423-zen. Tracking here in case we want to followup once the bug is resolved and CSS removed. |
Noting that WordPress/gutenberg#42470 addresses the issue and was merged yesterday. The fix should be included in Gutenberg 13.8. |
(Personal plan, so no CSS. Suggested disabling the "fixed background" setting for now, or shrinking the affected images as noted above, as temporary workarounds while we wait for the fix to be merged.) |
The user is reaching out for an update here 6433029-zen, it is said that the fix was to be deployed in Gutenberg 13.8, is there an update on the issue? |
@christianguerrag It looks like this was resolved, yes! The issue just wasn't closed when WordPress/gutenberg#42470 was merged. I took a quick look at the user in your ticket, and all their media images are HUUUUGE - like upwards of 3000-4000px in dimensions, and 4-8MB. It's possible they're just seeing the fixed cover block zoom in because of the size of their images, and a down-sized image should work better. I hope this helps! Thanks for the ping on this. 📌 ACTIONS
📌 Message to HEs
|
Quick summary
This is one I cannot reproduce, but I can give examples. It seems cover blocks with older code that worked well in January (could have been later) are now enlarging the image greatly.
Testing this on a test site is a problem as currently this issue is a blocker to testing: #64682 setting a new cover block results in the repeated background being added even if it's not selected. So we can't create a new cover block to see if the size is enlarged abnormally.
You can find an example in this ticket: 5329121-zen
And as this involves customer data, details are in this p2 post: pd4QKa-Bt-p2
Steps to reproduce
See the p2 post for specific details, this involves customer data and is current not possible to reproduce due to the other Github issue.
What you expected to happen
The cover blocks should not enlarge the pictures to huge dimensions for a fixed background.
What actually happened
They should look as they did in January.
Context
5329121-zen
Simple, Atomic or both?
Simple, Atomic
Theme-specific issue?
No response
Browser, operating system and other notes
No response
Reproducibility
Intermittent
Severity
Some (< 50%)
Available workarounds?
No but the platform is still usable
Workaround details
Setting the background to fixed will resolve the enlargement issue and repeated background issue.
The text was updated successfully, but these errors were encountered: