-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Management Dashboard: display amount of search results for query #65606
Comments
To whomever picks this up: this issue is probably impacted by #65644, so might want to wait until that lands. |
I've found that the search input doesn't persist the value when changing the tabs. Do you know if this is a good issue to add this fix? 65606_make-search-persistent.mp4 |
In #65644 the value is persisted on the URL, but not in the text input nor in the results. |
sejas
added a commit
that referenced
this issue
Jul 21, 2022
sejas
added a commit
that referenced
this issue
Jul 21, 2022
… own branch. This reverts commit 5a717a5.
sejas
added a commit
that referenced
this issue
Jul 21, 2022
5 tasks
p-jackson
added a commit
that referenced
this issue
Jul 22, 2022
…hook (#65769) * Move site filtering logic to useSitesTableFiltering hook * Refactor site tab controls into a generic, a8c-style, tab component * Lift ownership of filtered site data up into <SitesDashboard> * Lift responsibility for search state into <SitesDashboard> * Clarify ownership of which component/hook "controls" the search term * Fix typo in packages/search/README.md Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com> * Sites Dashboard: #65606 update number on tabs * Revert "Sites Dashboard: #65606 update number on tabs". Moving to its own branch. This reverts commit 5a717a5. * Sites Dashboard: fix eslint / Code Styles team city errors Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com> Co-authored-by: sejas <antonio@sejas.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Details
Extends #65505.
We should either update the count in the tabs or display a message alongside the search input informing the user of the number of sites that were returned according to their search.
@SaxonF, please let us know which approach is better for this case.
Done is
The text was updated successfully, but these errors were encountered: