Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Management Dashboard: display amount of search results for query #65606

Closed
1 task
zaguiini opened this issue Jul 14, 2022 · 6 comments
Closed
1 task

Comments

@zaguiini
Copy link
Contributor

zaguiini commented Jul 14, 2022

Details

Extends #65505.

We should either update the count in the tabs or display a message alongside the search input informing the user of the number of sites that were returned according to their search.

@SaxonF, please let us know which approach is better for this case.

Done is

  • The user knows how many sites were returned from their search
@danielbachhuber
Copy link
Contributor

To whomever picks this up: this issue is probably impacted by #65644, so might want to wait until that lands.

@sejas
Copy link
Member

sejas commented Jul 18, 2022

@zaguiini @danielbachhuber ,

I've found that the search input doesn't persist the value when changing the tabs.

Do you know if this is a good issue to add this fix?

65606_make-search-persistent.mp4

@danielbachhuber
Copy link
Contributor

I've found that the search input doesn't persist the value when changing the tabs.

@sejas Isn't this fixed by #65644?

@sejas
Copy link
Member

sejas commented Jul 18, 2022

In #65644 the value is persisted on the URL, but not in the text input nor in the results.

@sejas sejas self-assigned this Jul 18, 2022
@danielbachhuber
Copy link
Contributor

In #65644 the value is persisted on the URL, but not in the text input nor in the results.

@sejas Oh, you're right. It was working for me the other day, but now it's not. I'll see about fixing that.

@danielbachhuber
Copy link
Contributor

In #65644 the value is persisted on the URL, but not in the text input nor in the results.

@sejas This is now implemented with #65732

sejas added a commit that referenced this issue Jul 21, 2022
p-jackson added a commit that referenced this issue Jul 22, 2022
…hook (#65769)

* Move site filtering logic to useSitesTableFiltering hook

* Refactor site tab controls into a generic, a8c-style, tab component

* Lift ownership of filtered site data up into <SitesDashboard>

* Lift responsibility for search state into <SitesDashboard>

* Clarify ownership of which component/hook "controls" the search term

* Fix typo in packages/search/README.md

Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com>

* Sites Dashboard: #65606 update number on tabs

* Revert "Sites Dashboard: #65606 update number on tabs". Moving to its own branch.

This reverts commit 5a717a5.

* Sites Dashboard: fix eslint / Code Styles team city errors

Co-authored-by: Luis Felipe Zaguini <26530524+zaguiini@users.noreply.github.com>
Co-authored-by: sejas <antonio@sejas.es>
@sejas sejas closed this as completed Jul 22, 2022
@p-jackson p-jackson added this to the Sites Management Page milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants