Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles -> Typography -> Links overriding block-specific settings #74234

Closed
jamiepalatnik opened this issue Mar 8, 2023 · 5 comments
Closed
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. Navigation [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Feature Request Feature requests User Report This issue was created following a WordPress customer report

Comments

@jamiepalatnik
Copy link

What

Right now, it seems that global styles settings for Links override the Navigation block settings. For example, if there is a custom font size set for Links, selecting any font size in the Navigation block settings will not apply any changes.

I would expect to be able to customize the menu font size using the Navigation block settings, even if there are custom global styles settings.

Why

It can cause confusion when a user tries to change the font size of the menu in the Navigation block settings and nothing happens.

This was the case when trying to guide a user to change the font size in this follow-up ticket: 6027253-zd-woothemes

Discussed on Slack: p1678306490128969-slack-C03TY6J1A

How

No response

@jamiepalatnik jamiepalatnik added the [Type] Feature Request Feature requests label Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6027253-zen
  • 7465210-zen

@cuemarie
Copy link

cuemarie commented Mar 11, 2023

📌 ACTIONS

  • Feature request kept

📌 Note

This was reported as a feature request because in the slack thread linked above, it was noted that:

the font size for the Navigation block applies it to the li element, and the setting in Global Styles applies it to the a inside that li, so the a sizing wins

@cuemarie cuemarie added [Pri] High Address as soon as possible after BLOCKER issues Navigation User Report This issue was created following a WordPress customer report [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. labels Mar 11, 2023
@cuemarie cuemarie changed the title Allow font size to be set in Navigation block settings when there are custom global styles settings Global Styles -> Typography -> Links overriding block-specific settings Mar 11, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Mar 11, 2023
@cuemarie
Copy link

@liviopv
Copy link

liviopv commented Dec 17, 2023

  • 7465210-zd-a8c Custom font set for Links overrides Site Title Block

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 17, 2023
@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 4, 2024
@Copons Copons self-assigned this Sep 4, 2024
@Copons
Copy link
Contributor

Copons commented Sep 4, 2024

I'm closing this because it's a Core Gutenberg issue originating from the lack of Link style controls on blocks containing links. From a CSS cascading perspective, the problematic behavior is correct; however, in a real web design scenario, link styles are almost always overridden when used on primary layout elements (such as the site title or the navigation).

Here is a couple of directly related issues that are actively in progress:

@Copons Copons closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. Navigation [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Feature Request Feature requests User Report This issue was created following a WordPress customer report
Development

No branches or pull requests

4 participants