Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Plugins: add settings link #82

Closed
jeherve opened this issue Nov 18, 2015 · 13 comments
Closed

Jetpack Plugins: add settings link #82

jeherve opened this issue Nov 18, 2015 · 13 comments

Comments

@jeherve
Copy link
Member

jeherve commented Nov 18, 2015

Add a settings link to each plugin card, using the new Button component.

1bef9d74-65f5-11e5-9fc7-a63cb6cf1aed

Before we can expect that link that work, we need to make sure we catch each plugin. That could be tricky as it really depends on when and how the plugin decides to add the url to the plugins filter. Currently there is no standard way of doing this.

It might be easier to open a ticket in Core first, and suggest a new filter/function that would allow plugin devs to define where the canonical settings URL when the plugin includes one.

@rickybanister rickybanister added this to the Jetpack Plugin V2 - m1 - Single plugin view milestone Dec 17, 2015
@rickybanister
Copy link

This is related to #447

@enejb enejb removed this from the Jetpack Plugin V2 - m1 - Single plugin view milestone Jan 29, 2016
@lancewillett
Copy link
Contributor

Related #2206 but still not implemented. Jetpack plugins in Calypso don't have a settings like to go directly to wp-admin settings for that plugin.

@roundhill
Copy link
Contributor

It might be easier to open a ticket in Core first, and suggest a new filter/function that would allow plugin devs to define where the canonical settings URL when the plugin includes one.

Hey @jeherve we're thinking of adding something like this for at least the most popular plugins. Do you know if any effort was made to get this added to core?

@jeherve
Copy link
Member Author

jeherve commented Jan 30, 2017

I'm not aware of any work on that, I'm afraid.

@davewhitley
Copy link
Contributor

Here's my suggestion for the design. The proposed method in #6267 will pull more than just a settings link.

wp-admin:

screen shot 2017-02-06 at 2 17 14 pm

my design:

screen shot 2017-02-06 at 2 18 25 pm

@MichaelArestad
Copy link
Contributor

I would put the settings link in a secondary button underneath the plugin icon/name/author. I would put any other links with the other links to the left of the ratings chart.

@rickybanister
Copy link

@MichaelArestad the design you mention is in the OP of this thread.

@MichaelArestad
Copy link
Contributor

@rickybanister I know, but I want the button to be under the icon, too.

@roundhill
Copy link
Contributor

The Jetpack PR for the API is close to being merged. When we start working on this, let's make sure to add a stat for when the settings links are clicked. Ref: #11063

@roundhill
Copy link
Contributor

We have the API now so I started on the implementation of this in Calypso. I added the buttons beneath the icon and made the all Buttons that use the external link icon:

screen shot 2017-02-28 at 3 27 23 pm

I added some duplicates to test how it wraps:

screen shot 2017-02-28 at 3 25 44 pm

@rickybanister
Copy link

This is great, but an interesting point came up today during an in-person discussion about AT with @drw158:

Immediately after installing a new plugin, I'd have to imagine the most common thing someone wants to do is configure that plugin (by accessing some sort of settings link). This design is optimized more for accessing that settings link later.

We should do a mockup that overlays some kind of success banner that includes a link to configure settings (if we have access to the appropriate link).

@MichaelArestad
Copy link
Contributor

@rickybanister or it could just highlight the settings link somehow, but I see your point.

@roundhill
Copy link
Contributor

That's a good idea, although we don't have much data to work with. We get the link url and the link name (localized), so we could see if the url has something like settings or options in it to try and determine what we should link to in the success banner?

roundhill added a commit that referenced this issue Mar 10, 2017
* Adds plugin ‘action links’ buttons to the plugin detail view.

Fixes #82

* Add rel attribute for external link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants