-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image block: Expand on Click won't save in Global Styles on Simple Sites #82789
Comments
WordPress/gutenberg#54509 mentions "Expand on Click" can be enabled via Global Styles. |
📌 REPRODUCTION RESULTS
📌 FINDINGS/SCREENSHOTS/VIDEO Simple Site - (Gutenberg: v16.7.1) A3qFjS.mp4📌 ACTIONS
|
I'm unfamiliar with the new property (which is about opening the image in a lightbox, and it works fine when used at an individual block level). The GS API call contains this (among other things) as payload: {
"settings": {
"blocks": {
"core/image": {
"lightbox": {
"allowEditing": true,
"enabled": true
}
}
}
}
} The feature then adds lots of Typically, this kind of thing is stripped by the Dotcom KSES (although it doesn't seem to be the case here, since they work at a block level? 🤔 ). |
To rule out kses, you need to compare the response to the request - if the payload you mentioned isn't echoed back in the response it is very likely to be KSES ime |
@dsas Yes, that's what happens.
|
I tested this on a few pages and image blocks and it consistently worked.
I'm closing this. @happychait can you please test and confirm this feature works as you expect? |
Expand.on.Click.doesn.t.persist.in.Global.Styles.mp4
Quick summary
When "Expand on Click" toggle is enabled for Image block from the Styles panel, the choice is not saved and reverting to disabled state.the
Steps to reproduce
What you expected to happen
The "Expand on Click" will remain active and apply to all the image blocks added to the page or post editor.apply
What actually happened
The "Expand on Click" reverts to the disabled state.
Impact
One
Available workarounds?
No and the platform is unusable
Platform (Simple and/or Atomic)
Simple, Atomic
Logs or notes
Video of the problem
Expand.on.Click.doesn.t.persist.in.Global.Styles.mp4
The text was updated successfully, but these errors were encountered: