Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Move Top Bar Hotfix to wpcom-block-editor/default #87277

Closed
Copons opened this issue Feb 7, 2024 · 2 comments
Closed

Site Editor: Move Top Bar Hotfix to wpcom-block-editor/default #87277

Copons opened this issue Feb 7, 2024 · 2 comments

Comments

@Copons
Copy link
Contributor

Copons commented Feb 7, 2024

Details

In #87274 we released a hotfix for the Site Editor top bar in the wpcom folder of the wpcom-block-editor package.

It was a decision taken to ship the change quickly, but in fact, the change should live in the default folder, which is used by all site types, whereas wpcom is only loaded on Simple and Atomic sites.

To do so, though, we need to also update the package on Jetpack, to enqueue the new default/editor.min.css styles.

We should also keep an eye out to Gutenberg, and see if the issue was eventually fixed upstream!

Related

#87274

@dsas
Copy link
Contributor

dsas commented Feb 22, 2024

It was fixed in GB v17.7 via WordPress/gutenberg#58852 which has already been rolled out to all dotcom sites.

@Copons
Copy link
Contributor Author

Copons commented Feb 22, 2024

Thanks for checking @dsas!
I've moved the issue to the next sprint for convenience and raised the priority.

@Copons Copons closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants