Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better check for WPCOMness #97801

Open
andres-blanco opened this issue Dec 26, 2024 · 1 comment
Open

Better check for WPCOMness #97801

andres-blanco opened this issue Dec 26, 2024 · 1 comment
Labels
[Experiment] AI labels added [Feature] API [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation.

Comments

@andres-blanco
Copy link
Contributor

andres-blanco commented Dec 26, 2024

In the old credentials flow we were checking for WPCOMness based on the points_to_wpcom_servers function (fbhepr%2Skers%2Sjcpbz%2Snflap%2Qwbof%2Svapyhqrf%2Szvtengvba%2Snhgbzngrq%2Qzvtengvba.cuc%3Se%3Q0s050q9q%23116-og). In the AP flow we started relying on the analysis endpoint. This should change, since the points_to_wpcom_servers function is better at telling if a site is already on DOTCOM.

Action items

  • Verify where should this check go in the AP flow. To do this, the first step would be to add the check somewhere in this method: fbhepr%2Skers%2Sjcpbz%2Snflap%2Qwbof%2Svapyhqrf%2Szvtengvba%2Snhgbzngrq%2Qzvtengvba.cuc%3Se%3Q0s050q9q%23831-og and log when this case happens
  • Monitor the logs for the previously added entry
  • If it's common, then we need to figure out how to check before getting to the automated_migration_process_application_passwords job and redirect to the poll step. But we will cross that bridge if we need to.
@github-actions github-actions bot added [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] API [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. labels Dec 26, 2024
@andres-blanco andres-blanco changed the title Add check for points_to_wpcom_servers in the async job Better check for WPCOMness Dec 26, 2024
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Other Infrastructure: The issue relates to improving an internal infrastructure check for the async job, suggesting a focus on backend processes.
  • [Feature] API: The mention of the 'points_to_wpcom_servers' function indicates using an API for server communications in async jobs.
  • [Feature] Plugins: Since the function is used in conjunction with a prior credential flow job, it suggests integration with plugins to manage functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature] API [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation.
Projects
None yet
Development

No branches or pull requests

1 participant