Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload stats and chart before notifying ICFY #27834

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Upload stats and chart before notifying ICFY #27834

merged 3 commits into from
Oct 18, 2018

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Oct 12, 2018 •
edited
Loading

Fix a race condition where ICFY is notified and attempts to fetch stats artifacts before CircleCI has actually stored them.

p1539282285000100-slack-team-calypso

Changes proposed in this Pull Request

  • Conditionally notify ICFY after stats are stored

Testing instructions

  • e2e builds stats and notifies ICFY correctly?
  • ifcy report generated and fetched as expected?

@sirreal sirreal self-assigned this Oct 12, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/icfy-report-race

@ghost
Copy link

ghost commented Oct 12, 2018

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@sirreal sirreal requested a review from jsnajdr October 12, 2018 20:36
@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Oct 12, 2018
jsnajdr
jsnajdr approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The patch looks good and the CircleCI build for the branch proceeded 💯. I'm suggesting a drive-by bugfix for the ancestor commit calculation.

.circleci/config.yml Outdated Show resolved Hide resolved
@sirreal sirreal added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 18, 2018
@sirreal sirreal merged commit 3da9faf into master Oct 18, 2018
@sirreal sirreal deleted the fix/icfy-report-race branch October 18, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

Assignees

@sirreal sirreal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirreal @matticbot @jsnajdr