-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenboarding: add header #36525
Gutenboarding: add header #36525
Conversation
Looks like a bit of a structure emerging. How about something like this for the additional content:
We can do more with the rest too e.g.
Happy to move these if we agree (probably do all in a separate PR I guess). |
c2578c6
to
ff6c9a4
Compare
c8b7e29
to
554d4d1
Compare
f0e1758
to
81d2cff
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~196 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
05669f6
to
58dbb2c
Compare
81d2cff
to
4b22b71
Compare
Rebased and targeted to |
All Gutenberg core styles here should be imported from possible future |
With paObgF-BE-p2 in mind, what about replicating |
4b22b71
to
a050910
Compare
Valid points about components folder @ockham & @chriskmnds! Updated in a050910 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; one minor note.
(I didn't review the styling closely since it seems to be mostly copied from Gutenberg.)
Adds a basic header canvas with an example button.
As next steps outside this PR we need to somehow ensure that
.layout__content
and Calypso CSS reset styles don't collide with block editor.In this PR we introduce a bunch of Gutenberg stylesheets in Calypso, but those should be in future imported via
base-styles
package, being worked at WordPress/gutenberg#17883.Testing
/gutenboarding
in development env and confirm that you see a header that doesn't do anything yet. :-)