Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenboarding Design Selector: Add heading, srcset #38465

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Gutenboarding Design Selector: Add heading, srcset #38465

merged 5 commits into from
Dec 17, 2019

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Dec 17, 2019

Changes proposed in this Pull Request

Based on #38456. Add headings (according to mockup) and srcset for moar high-res images.

Testing instructions

http://calypso.localhost:3000/gutenboarding

@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg [Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. labels Dec 17, 2019
@ockham ockham requested a review from a team December 17, 2019 07:52
@ockham ockham self-assigned this Dec 17, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/gutenboarding-headers

@ockham ockham force-pushed the add/gutenboarding-headers branch from 3ce38f4 to 7ec32e6 Compare December 17, 2019 09:39
@ockham ockham requested review from a team as code owners December 17, 2019 09:39
@ockham ockham changed the base branch from gutenboarding/try-design-card to master December 17, 2019 09:40
@ockham
Copy link
Contributor Author

ockham commented Dec 17, 2019

Rebased.

simison
simison reviewed Dec 17, 2019
View reviewed changes
client/landing/gutenboarding/onboarding-block/design-selector/style.scss Outdated

h2,
h3 {
color: #23282d;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any sass variables available for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep: 0b4134d

sirreal
sirreal reviewed Dec 17, 2019
View reviewed changes
client/landing/gutenboarding/onboarding-block/design-selector/style.scss Outdated
Comment on lines 2 to 17
h1 {
color: #23282d;
font-size: 2em;
font-weight: bold;
margin-bottom: 0.25em;
text-align: center;
}

h2,
h3 {
color: #23282d;
font-size: 1.3em;
margin-bottom: 3em;
text-align: center;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer adding a specific classname for styling. It seems like using generic elements (even scoped like this) tends to come back to bite you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, can do

sirreal
sirreal approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sirreal sirreal added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 17, 2019
@ockham ockham merged commit bf82cc4 into master Dec 17, 2019
@ockham ockham deleted the add/gutenboarding-headers branch December 17, 2019 10:24
@matticbot
Copy link
Contributor

matticbot commented Dec 18, 2019 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~128 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +428 B  (+0.0%)     +128 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@sirreal sirreal sirreal approved these changes

Assignees

@ockham ockham

Labels
[Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ockham @matticbot @simison @sirreal