Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans Grid: enable accordion view as non-experimental #47491

Merged

Conversation

razvanpapadopol
Copy link

@razvanpapadopol razvanpapadopol commented Nov 17, 2020

*Editing Toolkit release notes: N/A (package API update)

Changes proposed in this Pull Request

  • Rename isExperimental prop to isAccordion for PlansGrid.
  • update usages in Step by Step launch and New Onboarding.
  • cleanup gutenboarding/feature-picker flag from the New Onboarding.

Testing instructions - nothing should change

  • Go to /new and reach plans step or open Plans modal
  • Accordion view should be displayed, as in production

- update usages in Step by Step launch and New Onboarding.
- cleanup gutenboarding/feature-picker flags from the New Onboarding.
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 17, 2020
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52859-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~47 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       -286 B  (-0.0%)      -47 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM and work as expected.

As a side note, I think we should try and track each PR with an Issue for more context and visibility.

@razvanpapadopol razvanpapadopol added the Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin label Nov 17, 2020
@razvanpapadopol razvanpapadopol merged commit 8c9157f into master Nov 17, 2020
@razvanpapadopol razvanpapadopol deleted the update/plans-grid-accordion-non-experimental branch November 17, 2020 15:00
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 17, 2020
@ockham ockham mentioned this pull request Nov 17, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants